Skip to content

test: log dynamic EvoNode helper exceptions - #7313

Closed
thepastaclaw wants to merge 1 commit into
dashpay:developfrom
thepastaclaw:fix-dip3-v19-exception-logging
Closed

test: log dynamic EvoNode helper exceptions#7313
thepastaclaw wants to merge 1 commit into
dashpay:developfrom
thepastaclaw:fix-dip3-v19-exception-logging

Conversation

@thepastaclaw

Copy link
Copy Markdown
Collaborator

Summary

  • include helper arguments and structured RPC error payloads when dynamic masternode/EvoNode setup is rejected
  • log unexpected dynamic helper exceptions with tracebacks before the existing accepted/rejected assertion fails
  • keep expected rejection cases as info-level logs

Context

This does not claim to fix the underlying feature_dip3_v19.py flake from #6702, but it should make the next failure more actionable instead of reducing it to dynamically_prepare_masternode failed or protx_evo rejected.

Testing

  • python3 -m py_compile test/functional/test_framework/test_framework.py
  • git diff --check
  • pre-PR code review: ship

@thepastaclaw

thepastaclaw commented May 8, 2026

Copy link
Copy Markdown
Collaborator Author

Review Gate

Commit: 1bbfbf99

  • Debounce: 16244m ago (need 30m)

  • CI checks: builds passed, 6/6 tests passed

  • CodeRabbit review: no comment yet

  • Off-peak hours: off-peak (03:42 AM PT Tuesday)

  • Run review now (check to override)

@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

@thepastaclaw

Copy link
Copy Markdown
Collaborator Author

Closing during authored-PR cleanup. This helper diagnostic draft was useful for investigation, but it should not remain open as a review item right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant