chore: clippy, cargo machete, rust update to 1.92 - #2905
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ gRPC Query Coverage Report |
78ab4eb to
cab54e0
Compare
| } | ||
|
|
||
| // Define default functions for serde | ||
| #[cfg(feature = "serde")] |
There was a problem hiding this comment.
These and others are weird, why would we only have this for serde?
| /// Defaults to the same as [platform_host](Config::platform_host). | ||
| #[serde(default)] | ||
| #[cfg_attr(not(feature = "network-testing"), allow(unused))] | ||
| #[allow(unused)] |
There was a problem hiding this comment.
Removed this field at all, it's not used.
| /// Defaults to the same as [platform_host](Config::platform_host). | ||
| #[serde(default)] | ||
| #[cfg_attr(not(feature = "network-testing"), allow(unused))] | ||
| #[allow(unused)] |
There was a problem hiding this comment.
adjusted feature annotations
|
|
||
| /// When platform_ssl is true, use the PEM-encoded CA certificate from provided absolute path to verify the server certificate. | ||
| #[serde(default)] | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
adjusted to only include this field when it's needed.
c9560bc
into
feat/platformAddresses
Issue being fixed or feature implemented
There are a few minor issues in the source code, like too many dependencies, failing clippy checks, etc.
What was done?
cargo macheteHow Has This Been Tested?
GHA https://github.com/dashpay/platform/actions/runs/20336671171
Failures:
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only