Skip to content

chore: clippy, cargo machete, rust update to 1.92 - #2905

Merged
QuantumExplorer merged 32 commits into
feat/platformAddressesfrom
fix/clippy-tests-etc
Dec 19, 2025
Merged

QuantumExplorer merged 32 commits into
feat/platformAddressesfrom
fix/clippy-tests-etc

Conversation

@lklimek

@lklimek lklimek commented Dec 17, 2025 •

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

There are a few minor issues in the source code, like too many dependencies, failing clippy checks, etc.

What was done?

  1. Fixed failing clippy checks
  2. Optimized unused deps with cargo machete
  3. Updated Rust to 1.92
  4. Updated systeminformation js lib in dashmate
  5. Fixed: drive-abci tests failed on Github Actions with SIGILL (Illegal Instruction)

How Has This Been Tested?

GHA https://github.com/dashpay/platform/actions/runs/20336671171

Failures:

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@coderabbitai

coderabbitai Bot commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/clippy-tests-etc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Dec 17, 2025 •

Copy link
Copy Markdown
Contributor

✅ gRPC Query Coverage Report

================================================================================
gRPC Query Coverage Report - NEW QUERIES ONLY
================================================================================

Total queries in proto: 49
Previously known queries: 47
New queries found: 2

================================================================================

New Query Implementation Status:
--------------------------------------------------------------------------------
✓ getAddressInfo                                /home/runner/work/platform/platform/packages/rs-sdk/src/platform/query.rs
✓ getAddressesInfos                             /home/runner/work/platform/platform/packages/rs-sdk/src/platform/fetch_many.rs

================================================================================
Summary:
--------------------------------------------------------------------------------
New queries implemented: 2 (100.0%)
New queries missing: 0 (0.0%)

Total known queries: 49
  - Implemented: 46
  - Not implemented: 2
  - Excluded: 1

Not implemented queries:
  - getConsensusParams
  - getTokenPreProgrammedDistributions

@lklimek lklimek changed the title chore: maintenance fixes in clippy, tests, cargo machete chore: maintenance fixes in clippy, tests, cargo machete, rust update to 1.92 Dec 17, 2025
@lklimek lklimek changed the title chore: maintenance fixes in clippy, tests, cargo machete, rust update to 1.92 chore: clippy, cargo machete, rust update to 1.92 Dec 17, 2025
@lklimek
lklimek force-pushed the fix/clippy-tests-etc branch from 78ab4eb to cab54e0 Compare December 17, 2025 14:00
Comment thread packages/rs-drive/src/config.rs Outdated
Comment thread packages/rs-drive/src/config.rs Outdated
}

// Define default functions for serde
#[cfg(feature = "serde")]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These and others are weird, why would we only have this for serde?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactored

/// Defaults to the same as [platform_host](Config::platform_host).
#[serde(default)]
#[cfg_attr(not(feature = "network-testing"), allow(unused))]
#[allow(unused)]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this field at all, it's not used.

Comment thread packages/rs-sdk/tests/fetch/config.rs Outdated
/// Defaults to the same as [platform_host](Config::platform_host).
#[serde(default)]
#[cfg_attr(not(feature = "network-testing"), allow(unused))]
#[allow(unused)]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted feature annotations

Comment thread packages/rs-sdk/tests/fetch/config.rs Outdated

/// When platform_ssl is true, use the PEM-encoded CA certificate from provided absolute path to verify the server certificate.
#[serde(default)]
#[allow(dead_code)]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted to only include this field when it's needed.

@QuantumExplorer
QuantumExplorer merged commit c9560bc into feat/platformAddresses Dec 19, 2025
310 of 318 checks passed
@QuantumExplorer
QuantumExplorer deleted the fix/clippy-tests-etc branch December 19, 2025 02:42
@thephez thephez added this to the v3.0 milestone Dec 22, 2025
@QuantumExplorer QuantumExplorer mentioned this pull request Sep 13, 2026
2 of 6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants