chore(deps): bump rust-dashcore to ca507a9 (v0.42-dev) - #3575
Conversation
Pulls in upstream key-wallet `Utxo::is_trusted` flag (#707) and the per-account balance diff carried on `WalletEvent` (#706). Adds `is_trusted` to the two `Utxo` struct literals in `platform-wallet`'s core-bridge: - `derive_new_utxos`: marks a Change output as trusted when the wallet also owns at least one input on the same transaction (mirrors key-wallet's "we authored this tx, the change is our funds returning" rule). `record.input_details` being non-empty is exactly that signal, since the wallet only records input details for inputs that spent our outpoints. - `derive_spent_utxos`: `false`. Per the existing comment, the synthetic UTXOs in the spent set are deleted by outpoint and the other flag fields are informational only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe workspace dependency versions for nine ChangesUTXO Trust Computation and Dependency Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Review GateCommit:
|
Issue being fixed or feature implemented
Pulls in the latest commits on the upstream
v0.42-devbranch of rust-dashcore:feat(key-wallet-manager): carry per-account balance diff onWalletEventfix(key-wallet): track self-send change in confirmed balance via newUtxo::is_trustedflagBumps the workspace pin from
8fe9ea3toca507a9for all 9 rust-dashcore crates.What was done?
Cargo.toml: bumped the sharedrevfordashcore,dash-network-seeds,dash-spv,dash-spv-ffi,key-wallet,key-wallet-ffi,key-wallet-manager,dash-network,dashcore-rpc.Cargo.lock: regenerated.packages/rs-platform-wallet/src/changeset/core_bridge.rs: added the newis_trustedfield to the twoUtxostruct literals (this is the only place in the platform repo that buildsUtxoby-field).derive_new_utxos— setsis_trusted = trueonOutputRole::Changeoutputs when the wallet also owns at least one input on the same transaction (!record.input_details.is_empty()). That matches key-wallet's "this is the change of a tx we authored, so it's our funds returning" rule.derive_spent_utxos— setsis_trusted = false. Per the existing comment, the synthetic UTXOs in the spent set are deleted by outpoint and the other flag fields are informational only.How Has This Been Tested?
cargo check --workspace— cleancargo check --workspace --tests— cleancargo clippy -p platform-wallet --tests— no warningscargo test -p platform-wallet --lib— 115/115 passingcargo fmt --all— no diffsBreaking Changes
None for this repo's public API. The upstream
Utxostruct gained a new field, which is an additive change to the persisted/serialized form (deserializes tofalseby default).Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
Improvements
Chores