Skip to content

chore: sync the pr-description skill with the PR template and title check - #5032

Merged
QuantumExplorer merged 1 commit into
v4.2-devfrom
claude/pr-description-drift
Sep 27, 2026
Merged

QuantumExplorer merged 1 commit into
v4.2-devfrom
claude/pr-description-drift

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

Basic explanation

What this does: The instruction file that tells Claude how to write PR descriptions had fallen out of date with the repository's real rules. It suggested a PR title label that our automatic title check rejects, it left out a checklist line that the real PR template has, and it named an old branch as the default. This brings it back in line and points it at the real rule files, so it cannot fall behind the same way again.

Value: Titles the skill suggests pass the PR title check the first time, descriptions match the current template, and a PR is never aimed at the old v4.0-dev branch by mistake.

Risks: Very low. Only the instruction file changes; no code, build or CI is touched.

Issue being fixed or feature implemented

.claude/skills/pr-description/SKILL.md copies facts from two files that have since changed:

  • .github/workflows/pr.yml allows 11 types and 25 scopes. The skill listed 7 types and 8 scopes, and one of its scopes, wasm-dpp, is not allowed, so a title built from it fails the check.
  • .github/PULL_REQUEST_TEMPLATE.md gained a GroveDB structure checklist item in dashpay/platform#4846. The skill's copy of the template did not have it.
  • The base-branch fallback was hardcoded to v4.0-dev.

Follow-up to dashpay/platform#5031.

What was done?

In .claude/skills/pr-description/SKILL.md:

  • Title types and scopes are no longer listed in the skill. It reads the types: and scopes: lists from .github/workflows/pr.yml, leaves the scope out when none fits (never inventing one), and states the check's rule that the subject must not start with an uppercase letter.
  • Template copy gains the GroveDB structure checklist item, so it matches .github/PULL_REQUEST_TEMPLATE.md again apart from the Basic explanation section. If the two ever differ, the skill now says to follow the file.
  • Base-branch fallback is the repository's default branch from gh repo view, and if that also fails the skill asks instead of guessing.

Example, a change that only touches packages/wasm-dpp:

Before: skill offers scope `wasm-dpp`
        Suggested title: fix(wasm-dpp): ...   -> PR title check fails
After:  `wasm-dpp` is not in pr.yml's scopes, so the scope is left out
        Suggested title: fix: ...             -> PR title check passes

Example, when origin/HEAD cannot be resolved:

Before: base branch = v4.0-dev
After:  base branch = gh repo view --json defaultBranchRef (v4.2-dev today); ask if that fails too

How Has This Been Tested?

Documentation-only change to a skill file.

  • Diffed the skill's template copy against .github/PULL_REQUEST_TEMPLATE.md on v4.2-dev: identical apart from the Basic explanation section.
  • Counted the allowed lists in .github/workflows/pr.yml on v4.2-dev: 11 types, 25 scopes, no wasm-dpp.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed
  • If I added or changed GroveDB structure, I described it in the area's structure.rs, regenerated grovedb-structure.json, and checked the structure viewer link posted on this pull request

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

PR Hygiene · bcf0a08

  • Bots — coderabbitai not yet · thepastaclaw not yet — /skip-bots proceeds without the ones not yet reported
  • Self-review — post /self-reviewed once the bots are done
  • Within your 5 open PRs
  • Build running
  • Approvals — you own every area touched; none needed

When every box is checked the PR Hygiene check passes and this can merge.

…heck

The skill had drifted from the files it copies:
- It suggested the scope `wasm-dpp`, which the PR title check rejects,
  and listed 8 of the 25 allowed scopes and 7 of the 11 allowed types.
  It now reads both lists from .github/workflows/pr.yml and states the
  lowercase-subject rule the check enforces.
- Its template copy lacked the GroveDB structure checklist item. It now
  matches .github/PULL_REQUEST_TEMPLATE.md, and the file wins if the two
  differ again.
- Its base-branch fallback was the stale `v4.0-dev`. It now falls back
  to the GitHub default branch, then asks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: dashpay/platform/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: fb7d7321-3623-49f8-9702-b2de876b10dd

📥 Commits

Reviewing files that changed from the base of the PR and between b43b030 and bcf0a08.

📒 Files selected for processing (1)
  • .claude/skills/pr-description/SKILL.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added this to the v4.2.0 milestone Sep 27, 2026
@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Sep 27, 2026
@thepastaclaw

thepastaclaw commented Sep 27, 2026 •

Copy link
Copy Markdown
Collaborator

🕓 Queued for automated review — 3rd in line, estimated start in ~30 min (commit bcf0a08)
Estimated review time once started: ~1.0 h (two-phase automated review; median of recent runs).

  • Request priority review — click to move this review to the front of the queue.

@QuantumExplorer QuantumExplorer left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@QuantumExplorer
QuantumExplorer merged commit 52cd646 into v4.2-dev Sep 27, 2026
19 of 20 checks passed
@QuantumExplorer
QuantumExplorer deleted the claude/pr-description-drift branch September 27, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-bots Waiting for the review bots to report on this head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants