Repository navigation
chore: sync the pr-description skill with the PR template and title check - #5032
Conversation
…heck The skill had drifted from the files it copies: - It suggested the scope `wasm-dpp`, which the PR title check rejects, and listed 8 of the 25 allowed scopes and 7 of the 11 allowed types. It now reads both lists from .github/workflows/pr.yml and states the lowercase-subject rule the check enforces. - Its template copy lacked the GroveDB structure checklist item. It now matches .github/PULL_REQUEST_TEMPLATE.md, and the file wins if the two differ again. - Its base-branch fallback was the stale `v4.0-dev`. It now falls back to the GitHub default branch, then asks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 51 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: dashpay/platform/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🕓 Queued for automated review — 3rd in line, estimated start in ~30 min (commit bcf0a08)
|
Basic explanation
What this does: The instruction file that tells Claude how to write PR descriptions had fallen out of date with the repository's real rules. It suggested a PR title label that our automatic title check rejects, it left out a checklist line that the real PR template has, and it named an old branch as the default. This brings it back in line and points it at the real rule files, so it cannot fall behind the same way again.
Value: Titles the skill suggests pass the PR title check the first time, descriptions match the current template, and a PR is never aimed at the old
v4.0-devbranch by mistake.Risks: Very low. Only the instruction file changes; no code, build or CI is touched.
Issue being fixed or feature implemented
.claude/skills/pr-description/SKILL.mdcopies facts from two files that have since changed:.github/workflows/pr.ymlallows 11 types and 25 scopes. The skill listed 7 types and 8 scopes, and one of its scopes,wasm-dpp, is not allowed, so a title built from it fails the check..github/PULL_REQUEST_TEMPLATE.mdgained a GroveDB structure checklist item in dashpay/platform#4846. The skill's copy of the template did not have it.v4.0-dev.Follow-up to dashpay/platform#5031.
What was done?
In
.claude/skills/pr-description/SKILL.md:types:andscopes:lists from.github/workflows/pr.yml, leaves the scope out when none fits (never inventing one), and states the check's rule that the subject must not start with an uppercase letter..github/PULL_REQUEST_TEMPLATE.mdagain apart from the Basic explanation section. If the two ever differ, the skill now says to follow the file.gh repo view, and if that also fails the skill asks instead of guessing.Example, a change that only touches
packages/wasm-dpp:Example, when
origin/HEADcannot be resolved:How Has This Been Tested?
Documentation-only change to a skill file.
.github/PULL_REQUEST_TEMPLATE.mdonv4.2-dev: identical apart from the Basic explanation section..github/workflows/pr.ymlonv4.2-dev: 11 types, 25 scopes, nowasm-dpp.Breaking Changes
None.
Checklist:
structure.rs, regeneratedgrovedb-structure.json, and checked the structure viewer link posted on this pull requestFor repository code-owners and collaborators only
🤖 Generated with Claude Code
PR Hygiene ·
bcf0a08/skip-botsproceeds without the ones not yet reported/self-reviewedonce the bots are doneWhen every box is checked the
PR Hygienecheck passes and this can merge.