Repository navigation
ci: restore legacy runner image template compatibility - #5155
ktechmidas merged 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: dashpay/platform/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🕓 Queued for automated review — 4th in line, estimated start in ~30 min (commit 201c2f9)
|
Pick up #5155 (restore legacy runner image template compatibility). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Issue being fixed or feature implemented
Fix the runner-image candidate controller/template mismatch observed in Platform PR #5151's failed image build.
The trusted controller at
07811cd919f6956ba9c6d69a3a1bff4550eb3761cannot render the still-pinned AMD64 recipee49e8bc9977f5f961a76ba1d1f7673c72173679f: its template contains@@NDK_VERSION@@and@@CMDLINE_VERSION@@, but the newer renderer supplies only the replacement Android environment/path blocks. Materialization fails before Docker builds or application tests start.What was done?
control_revisionto the same immutable controller fix:aaea7df12716c386db223ea67a853b6b0efbd45a.Companion: dashpay/dash-selfhosted-image#7. Review/merge that dependency before this pin update. This PR targets v4.2-dev as requested; other consuming branches need the same reviewed pin before a fresh candidate run. Rerunning the old workflow snapshot is not proof of the fix.
How Has This Been Tested?
36469557091.This fixes and tests materialization. Full image-build/KVM CI results will be reported separately; no existing failure is treated as green merely because the pin changed.
Breaking Changes
None. No protocol, application behavior, manifest or image dependency change.
Checklist:
structure.rs, regeneratedgrovedb-structure.json, and checked the structure viewer link posted on this pull request (not applicable)For repository code-owners and collaborators only
PR Hygiene ·
201c2f9/skip-botsproceeds without the ones not yet reported.github/workflows/runner-image-candidate.yml) — QuantumExplorer or shumkovWhen every box is checked the
PR Hygienecheck passes and this can merge.