Skip to content

ci: restore legacy runner image template compatibility - #5155

Merged
ktechmidas merged 1 commit into
dashpay:v4.2-devfrom
infraclaw-dash:fix/runner-template-compat-v42-20260928
Sep 28, 2026
Merged

ktechmidas merged 1 commit into
dashpay:v4.2-devfrom
infraclaw-dash:fix/runner-template-compat-v42-20260928

Conversation

@infraclaw-dash

@infraclaw-dash infraclaw-dash commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Fix the runner-image candidate controller/template mismatch observed in Platform PR #5151's failed image build.

The trusted controller at 07811cd919f6956ba9c6d69a3a1bff4550eb3761 cannot render the still-pinned AMD64 recipe e49e8bc9977f5f961a76ba1d1f7673c72173679f: its template contains @@NDK_VERSION@@ and @@CMDLINE_VERSION@@, but the newer renderer supplies only the replacement Android environment/path blocks. Materialization fails before Docker builds or application tests start.

What was done?

  • Update both the reusable-workflow SHA and control_revision to the same immutable controller fix: aaea7df12716c386db223ea67a853b6b0efbd45a.
  • Keep this Platform change to the CI workflow only. No application code, package dependencies, runner requirements, image recipes, runner labels or deployment changes.
  • The companion controller repair restores the two legacy Android substitutions only for full-profile images, while retaining newer full/Rust-profile rendering and strict rejection of unknown placeholders.

Companion: dashpay/dash-selfhosted-image#7. Review/merge that dependency before this pin update. This PR targets v4.2-dev as requested; other consuming branches need the same reviewed pin before a fresh candidate run. Rerunning the old workflow snapshot is not proof of the fix.

How Has This Been Tested?

  • Reproduced the original failure with the downloaded manifest and exact pinned template from run 36469557091.
  • Platform runner-routing and release-boundary tests: 24 passed before and after the pin update.
  • Workflow syntax checked with actionlint.
  • Controller suite: 49 tests, 48 passed and one opt-in Docker test skipped. The new regression fails against the old controller; exact historical materialization passes with the fix and matches its known-good output. Current AMD64/ARM64 rendered Dockerfiles are byte-for-byte unchanged.

This fixes and tests materialization. Full image-build/KVM CI results will be reported separately; no existing failure is treated as green merely because the pin changed.

Breaking Changes

None. No protocol, application behavior, manifest or image dependency change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (compatibility intent is documented in the controller repair)
  • I have added or updated relevant unit/integration/functional/e2e tests (controller regression coverage in companion PR)
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any (not applicable)
  • I have made corresponding changes to the documentation if needed (not needed for a compatible controller pin)
  • If I added or changed GroveDB structure, I described it in the area's structure.rs, regenerated grovedb-structure.json, and checked the structure viewer link posted on this pull request (not applicable)

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

PR Hygiene · 201c2f9

  • Bots — coderabbitai not yet · thepastaclaw not yet — /skip-bots proceeds without the ones not yet reported
  • Self-review — not asked of a bot author
  • Within your 5 open PRs
  • Build green
  • Approvals
    • files with no dedicated owner (.github/workflows/runner-image-candidate.yml) — QuantumExplorer or shumkov

When every box is checked the PR Hygiene check passes and this can merge.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: dashpay/platform/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: dac1340f-c747-41af-91d7-559fff2d3259

📥 Commits

Reviewing files that changed from the base of the PR and between 1464314 and 201c2f9.

📒 Files selected for processing (1)
  • .github/workflows/runner-image-candidate.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Sep 28, 2026
@github-actions github-actions Bot added this to the v4.2.0 milestone Sep 28, 2026
@thepastaclaw

thepastaclaw commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

🕓 Queued for automated review — 4th in line, estimated start in ~30 min (commit 201c2f9)
Estimated review time once started: ~1.0 h (two-phase automated review; median of recent runs).

  • Request priority review — click to move this review to the front of the queue.

@ktechmidas
ktechmidas merged commit 9f78909 into dashpay:v4.2-dev Sep 28, 2026
19 of 20 checks passed
PastaPastaPasta added a commit that referenced this pull request Sep 28, 2026
Pick up #5155 (restore legacy runner image template compatibility).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@PastaPastaPasta PastaPastaPasta mentioned this pull request Sep 28, 2026
2 of 24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-bots Waiting for the review bots to report on this head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants