Skip to content

feat(dpp): document $createdAt and $updatedAt validation - #948

Merged
shumkov merged 5 commits into
masterfrom
feat/additional-dpp-validations
May 15, 2023
Merged

feat(dpp): document $createdAt and $updatedAt validation#948
shumkov merged 5 commits into
masterfrom
feat/additional-dpp-validations

Conversation

@jawid-h

@jawid-h jawid-h commented Apr 20, 2023

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Check that $updatedAt property is not equal to $createdAt for document replace transition

What was done?

  • added additional error
  • added additional validation

How Has This Been Tested?

  • unit tests

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h changed the title chore: validate $createdAt and $updatedAt are not equal for document replace transition feat(rs-dpp): validate $createdAt and $updatedAt are not equal for document replace transition Apr 20, 2023
Comment thread packages/rs-dpp/src/errors/consensus/codes.rs
@shumkov shumkov changed the title feat(rs-dpp): validate $createdAt and $updatedAt are not equal for document replace transition feat(dpp): validate $createdAt and $updatedAt are not equal for document replace transition May 10, 2023
@shumkov
shumkov changed the base branch from v0.24-dev to master May 10, 2023 07:38
shumkov
shumkov previously approved these changes May 10, 2023

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov
shumkov changed the base branch from master to v0.25-dev May 10, 2023 09:57
@shumkov
shumkov dismissed their stale review May 10, 2023 09:57

The base branch was changed.

@shumkov
shumkov changed the base branch from v0.25-dev to master May 10, 2023 09:58
@shumkov shumkov added this to the v0.24.x milestone May 10, 2023
antouhou
antouhou previously approved these changes May 11, 2023
@shumkov shumkov changed the title feat(dpp): validate $createdAt and $updatedAt are not equal for document replace transition feat(dpp): document $createdAt and $updatedAt validation May 11, 2023
@shumkov

shumkov commented May 11, 2023

Copy link
Copy Markdown
Collaborator

I just wondering why we do validation of document data in the state but not in basic?

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov
shumkov merged commit 45be18a into master May 15, 2023
@shumkov
shumkov deleted the feat/additional-dpp-validations branch May 15, 2023 09:34
shumkov pushed a commit that referenced this pull request May 16, 2023
Co-authored-by: Anton Suprunchuk <antouhou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants