Skip to content

feat: agentstudio add feature tool approval, event deltas, session resources,security - #192

Merged
luk384090-cloud merged 2 commits into
mainfrom
dev/agent-delta-feat
Sep 10, 2026
Merged

feat: agentstudio add feature tool approval, event deltas, session resources,security#192
luk384090-cloud merged 2 commits into
mainfrom
dev/agent-delta-feat

Conversation

@foleydang

@foleydang foleydang commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Description

  • P0: tool_approval_request/response (replaces tool_confirmation), StopReason pending_batch_id/pending_call_ids, PermissionPolicy, SessionStatus rescheduled/deleted, types[] query fix, error/pending accessors, status-based error mapping (no approval code enumeration)
  • P1: event_deltas streaming (event_start/event_delta/text_deltas), SessionResources (add/retrieve/list/delete), SessionThreads (list/retrieve/archive/events.list), Security (overview/list_agent_logs)
  • P2: Message data accessors (model_request_end/outcome_evaluation/ thread_status/thread_created/session_updated/thread_message_routing)

Related Issue: Fixes #[issue_number] or Relates to #[issue_number] None

Security Considerations: [Check if API keys or sensitive credentials are exposed in code/logs] Security

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactoring

Component(s) Affected

  • Model
  • Application
  • Common
  • Documentation
  • Tests
  • CI/CD

Checklist

  • Pre-commit hooks pass
  • Tests pass locally
  • Documentation updated (if needed)
  • Ready for review

Testing

[How to test these changes]

Additional Notes

[Optional: any other context]

…eads, security, message accessors

- P0: tool_approval_request/response (replaces tool_confirmation),
  StopReason pending_batch_id/pending_call_ids, PermissionPolicy,
  SessionStatus rescheduled/deleted, types[] query fix, error/pending
  accessors, status-based error mapping (no approval code enumeration)
- P1: event_deltas streaming (event_start/event_delta/text_deltas),
  SessionResources (add/retrieve/list/delete), SessionThreads
  (list/retrieve/archive/events.list), Security (overview/list_agent_logs)
- P2: Message data accessors (model_request_end/outcome_evaluation/
  thread_status/thread_created/session_updated/thread_message_routing)

Co-Authored-By: Claude Code <noreply@anthropic.com>
- session_events.py: 4 stop-set tuples referenced deleted SessionStatus.RESCHEDULING,
  causing AttributeError on every stream's normal end (session_status: idle)
- Extracted _TERMINAL_STATUSES tuple (DRY: sync+async text_stream/text_deltas)
- Added from_raw_events classmethod for testing without private member access
- Added test_text_stream_stops_on_session_status_idle regression test

Co-Authored-By: Claude Code <noreply@anthropic.com>
@luk384090-cloud
luk384090-cloud merged commit a4476e3 into main Sep 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants