fix(kernel): honor cursor row_limit - #916
Merged
Merged
Conversation
There was a problem hiding this comment.
Verdict: 1 Medium
Solid, well-tested fix — the buffer/limit mechanics (remaining-limit math, batch slicing, exact-boundary exhaustion, metadata paths left unlimited) are all correct and covered by unit + e2e tests. One medium concern: row_limit=0 is treated as a hard zero-row cap here, which diverges from the SEA backend where 0 means unlimited (requests.py:48) — a potential silent behavior change on backend switch worth reconciling.
vikrantpuppala
temporarily deployed
to
azure-prod
August 18, 2026 06:32 — with 
GitHub Actions
Inactive
eric-wang-1990
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PECOBLR-4127.
The Kernel adapter now applies the cursor's
row_limitat the streaming result boundary for row and Arrow fetches, includingrow_limit=0. Metadata result sets remain unaffected.Tested with the focused Kernel unit suite (134 passed); added Kernel E2E coverage for limits 0, 1, and 5.
This PR was created with GitHub MCP.