Skip to content

OECDQuaterlyGDP | lint error fix - #2162

Open
Ashwani725 wants to merge 2 commits into
datacommonsorg:masterfrom
Ashwani725:OECDQuaterlyGDP
Open

OECDQuaterlyGDP | lint error fix#2162
Ashwani725 wants to merge 2 commits into
datacommonsorg:masterfrom
Ashwani725:OECDQuaterlyGDP

Conversation

@Ashwani725

Copy link
Copy Markdown

The PR is raised to fix validation issue in OECDQuaterlyGDP. The Job is showing lint error that occur due to change in ref_area code changes in input source file To fix this, pv mapping is updated and added new ref_Area in it, Also raised a CL to add new stat vars.
Also added the Golden checks and tested them successfully.
Files added: manifest.json, pvmap.csv, golden_data/, validation_config.json
Test result: validation output

@google-cla

google-cla Bot commented Aug 17, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces validation configuration and golden data files for the OECD quarterly GDP import. Specifically, it adds golden observation and summary report CSVs, registers the validation configuration in the manifest, ignores non-country regions ('EU' and 'EA') in the PV map, and defines validation rules in validation_config.json. The review feedback highlights a formatting issue with a misplaced closing brace and an inconsistent uppercase rule ID in the validation configuration.

Comment thread statvar_imports/oecd/quarterly_gdp/validation_config.json Outdated
Comment thread statvar_imports/oecd/quarterly_gdp/validation_config.json Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant