OECDQuaterlyGDP | lint error fix - #2162
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request introduces validation configuration and golden data files for the OECD quarterly GDP import. Specifically, it adds golden observation and summary report CSVs, registers the validation configuration in the manifest, ignores non-country regions ('EU' and 'EA') in the PV map, and defines validation rules in validation_config.json. The review feedback highlights a formatting issue with a misplaced closing brace and an inconsistent uppercase rule ID in the validation configuration.
The PR is raised to fix validation issue in OECDQuaterlyGDP. The Job is showing lint error that occur due to change in ref_area code changes in input source file To fix this, pv mapping is updated and added new ref_Area in it, Also raised a CL to add new stat vars.
Also added the Golden checks and tested them successfully.
Files added: manifest.json, pvmap.csv, golden_data/, validation_config.json
Test result: validation output