Table configs as protos - #1780
Merged
Merged
Conversation
Ekrekr
requested review from
DiasDauletov
and removed request for
a team and
DiasDauletov
December 27, 2024 16:42
added 6 commits
January 2, 2025 14:20
Ekrekr
requested review from
a team and
DiasDauletov
and removed request for
a team
January 3, 2025 14:51
| * within SQLX files, or when using a [Contextable](#Contextable) argument with the JS API. | ||
| * @hidden | ||
| * This maintains backwards compatability with older versions. | ||
| * TODO(ekrekr): consider breaking backwards compatability of these in v4. |
Contributor
There was a problem hiding this comment.
for all the TODO(erkerkr) probably it is better to have TODO(issue)
Contributor
Author
There was a problem hiding this comment.
There are quite a lot of these, I'll make a triage plan and turn them into bugs in one go
DiasDauletov
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes duplicate javascript interfaces, and duplicate constructors, for the view and incremental table types from the table action.
This means that we're very close to being able to generate a single source of truth for what options are valid for SQLX config blocks, and for javascript interface methods.
It also removes a lot of tech debt, around having to maintain multiple definitions of what are essentially the same options.