Skip to content

fix high impact bugs - #515

Merged
XiangpengHao merged 1 commit into
mainfrom
bug-audit
Sep 3, 2026
Merged

XiangpengHao merged 1 commit into
mainfrom
bug-audit

Conversation

@XiangpengHao

Copy link
Copy Markdown
Collaborator

Found by codex audit, those are indeed correctness bugs

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 1 medium

Results:
1 new issue

Category Results
Complexity 1 medium

View in Codacy

🟢 Metrics 4 complexity · 0 duplication

Metric Results
Complexity 4
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.47%. Comparing base (7554acd) to head (0232d3e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
+ Coverage   84.35%   84.47%   +0.11%     
==========================================
  Files          85       85              
  Lines       19618    19724     +106     
  Branches    19618    19724     +106     
==========================================
+ Hits        16548    16661     +113     
+ Misses       2757     2751       -6     
+ Partials      313      312       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@XiangpengHao
XiangpengHao merged commit feb0fd9 into main Sep 3, 2026
15 checks passed
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Comparison

Current: 0a24ed4c (Liquid) vs Baseline: 0a24ed4c (DataFusionDefault)

Query Cold Time Δ Warm Time Δ CPU Time Δ
Q1 2.0ms (2.0ms) +0.0% 0.000ms (0.000ms) +0.0% 0.000ms (0.000ms) +0.0%
Q2 14.0ms (8.0ms) +75.0% 5.5ms (6.0ms) -8.3% 8.5ms (7.5ms) +13.3%
Q3 15.0ms (13.0ms) +15.4% 6.0ms (12.5ms) -52.0% 3.0ms (22.0ms) -86.4%
Q4 17.0ms (12.0ms) +41.7% 5.0ms (11.0ms) -54.5% 3.0ms (24.5ms) -87.8%
Q5 54.0ms (51.0ms) +5.9% 43.0ms (53.0ms) -18.9% 4.0ms (26.0ms) -84.6%
Q6 165.0ms (118.0ms) +39.8% 75.5ms (113.5ms) -33.5% 20.0ms (79.0ms) -74.7%
Q7 1.0ms (1.0ms) +0.0% 1.0ms (0.000ms) +inf% 0.000ms (0.000ms) +0.0%
Q8 8.0ms (5.0ms) +60.0% 4.0ms (6.0ms) -33.3% 9.0ms (6.5ms) +38.5%
Q9 92.0ms (86.0ms) +7.0% 75.0ms (85.0ms) -11.8% 5.5ms (43.5ms) -87.4%
Q10 88.0ms (91.0ms) -3.3% 67.5ms (93.0ms) -27.4% 6.0ms (63.0ms) -90.5%
Q11 55.0ms (25.0ms) +120.0% 33.5ms (27.0ms) +24.1% 81.0ms (37.0ms) +118.9%
Q12 59.0ms (28.0ms) +110.7% 35.5ms (29.0ms) +22.4% 83.0ms (43.5ms) +90.8%
Q13 189.0ms (123.0ms) +53.7% 86.0ms (120.0ms) -28.3% 81.0ms (83.0ms) -2.4%
Q14 339.0ms (155.0ms) +118.7% 130.5ms (154.5ms) -15.5% 92.5ms (113.5ms) -18.5%
Q15 253.0ms (112.0ms) +125.9% 85.5ms (111.5ms) -23.3% 88.5ms (97.5ms) -9.2%
Q16 94.0ms (93.0ms) +1.1% 84.0ms (94.5ms) -11.1% 4.0ms (26.5ms) -84.9%
Q17 383.0ms (220.0ms) +74.1% 222.0ms (212.5ms) +4.5% 89.0ms (113.0ms) -21.2%
Q18 415.0ms (214.0ms) +93.9% 221.5ms (213.0ms) +4.0% 87.5ms (112.0ms) -21.9%
Q19 622.0ms (426.0ms) +46.0% 366.5ms (426.0ms) -14.0% 107.5ms (155.5ms) -30.9%
Q20 15.0ms (14.0ms) +7.1% 4.5ms (12.0ms) -62.5% 10.0ms (23.0ms) -56.5%
Q21 822.0ms (210.0ms) +291.4% 282.0ms (191.0ms) +47.6% 553.5ms (302.5ms) +83.0%
Q22 1.15s (186.0ms) +519.9% 368.0ms (187.5ms) +96.3% 170.0ms (379.0ms) -55.1%
Q23 2.24s (515.0ms) +334.6% 1.05s (520.0ms) +102.2% 568.5ms (809.5ms) -29.8%
Q24 18.12s (1.01s) +1694.4% 804.0ms (1.01s) -20.6% 647.5ms (2.73s) -76.3%
Q25 219.0ms (73.0ms) +200.0% 22.0ms (61.5ms) -64.2% 49.0ms (125.5ms) -61.0%
Q26 126.0ms (47.0ms) +168.1% 30.0ms (51.5ms) -41.7% 77.0ms (90.5ms) -14.9%
Q27 206.0ms (63.0ms) +227.0% 33.0ms (63.5ms) -48.0% 88.0ms (125.0ms) -29.6%
Q28 966.0ms (239.0ms) +304.2% 289.0ms (241.0ms) +19.9% 372.0ms (314.0ms) +18.5%
Q29 1.85s (1.05s) +76.2% 1.10s (1.06s) +4.1% 611.0ms (384.5ms) +58.9%
Q30 26.0ms (30.0ms) -13.3% 24.5ms (31.5ms) -22.2% 7.0ms (20.0ms) -65.0%
Q31 300.0ms (112.0ms) +167.9% 65.5ms (102.0ms) -35.8% 51.0ms (142.5ms) -64.2%
Q32 548.0ms (105.0ms) +421.9% 87.5ms (106.5ms) -17.8% 60.5ms (154.0ms) -60.7%
Q33 337.0ms (314.0ms) +7.3% 294.0ms (303.5ms) -3.1% 9.5ms (74.5ms) -87.2%
Q34 1.05s (428.0ms) +144.9% 476.0ms (424.0ms) +12.3% 356.0ms (301.0ms) +18.3%
Q35 1.10s (422.0ms) +161.4% 450.5ms (426.0ms) +5.8% 353.5ms (297.5ms) +18.8%
Q36 92.0ms (99.0ms) -7.1% 78.0ms (87.0ms) -10.3% 4.5ms (25.0ms) -82.0%
Q37 312.0ms (122.0ms) +155.7% 87.5ms (109.0ms) -19.7% 42.5ms (79.0ms) -46.2%
Q38 75.0ms (46.0ms) +63.0% 32.5ms (48.5ms) -33.0% 22.5ms (27.0ms) -16.7%
Q39 275.0ms (53.0ms) +418.9% 12.0ms (55.5ms) -78.4% 10.5ms (82.0ms) -87.2%
Q40 781.0ms (222.0ms) +251.8% 230.5ms (200.0ms) +15.2% 84.0ms (138.0ms) -39.1%
Q41 24.0ms (19.0ms) +26.3% 11.0ms (23.0ms) -52.2% 8.5ms (20.0ms) -57.5%
Q42 21.0ms (21.0ms) +0.0% 10.5ms (21.0ms) -50.0% 8.5ms (18.0ms) -52.8%
Q43 17.0ms (14.0ms) +21.4% 11.5ms (14.0ms) -17.9% 9.0ms (9.5ms) -5.3%

⚠️ LiquidCache is slower on 8 queries (warm)

  • Q7: warm +inf% (1.0ms vs 0.000ms)
  • Q23: warm +102.2% (1.05s vs 520.0ms)
  • Q22: warm +96.3% (368.0ms vs 187.5ms)
  • Q21: warm +47.6% (282.0ms vs 191.0ms)
  • Q11: warm +24.1% (33.5ms vs 27.0ms)
  • Q12: warm +22.4% (35.5ms vs 29.0ms)
  • Q28: warm +19.9% (289.0ms vs 241.0ms)
  • Q40: warm +15.2% (230.5ms vs 200.0ms)

Compared Liquid vs DataFusionDefault on the same runner
Regressions: warm-time increases of at least 15%. Cold Time: first iteration; Warm Time: median of remaining iterations.

@XiangpengHao
XiangpengHao deleted the bug-audit branch September 4, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant