Skip to content

test(isotp): dispose the channel and the receive CTS deterministically #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dborgards merged 2 commits into from
Sep 11, 2026
Merged

test(isotp): dispose the channel and the receive CTS deterministically #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b57d5ed
test(isotp): dispose the channel and the receive CTS deterministically
dborgards Sep 10, 2026
6e0a8bd
Merge branch 'main' into test/dispose-hygiene
dborgards Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tests/CanKit.Pro.Tests/TestCases/IsoTp/IsoTpChannelIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,11 @@ public async Task Dispose_Unblocks_Pending_ReceiveAsync()
using var busA = OpenClassic(session, 0);
using var busB = OpenClassic(session, 1);

var channel = IsoTpFactory.Open(busA, IsoTpEndpoint.Normal(0x123, 0x321), FastOptions());
// `using` on top of the two explicit calls below: the point of this test is that Dispose
// is idempotent, so a third call at scope exit changes nothing -- but without it a
// ReceiveAsync that throws would leave the channel open for the rest of the run
// (CodeQL cs/dispose-not-called-on-throw).
using var channel = IsoTpFactory.Open(busA, IsoTpEndpoint.Normal(0x123, 0x321), FastOptions());
var recvTask = channel.ReceiveAsync();
// Idempotent dispose
channel.Dispose();
Expand Down Expand Up @@ -795,7 +799,10 @@ public async Task Send_Faults_With_The_Bus_Layer_Exception_And_Channel_Remains_U
"the failure the bus layer reported must reach the caller unrewritten");

// Gate free and _tx cleared: the very next send goes through end to end.
var recvTask = receiver.ReceiveAsync(new CancellationTokenSource(ShortTimeout).Token);
// Owned rather than inline, so the timer it holds is released when the test ends and
// not when the finalizer gets round to it (CodeQL cs/local-not-disposed).
using var recvCts = new CancellationTokenSource(ShortTimeout);
var recvTask = receiver.ReceiveAsync(recvCts.Token);
byte[] normal = { 0x11, 0x22, 0x33 };
await sender.SendAsync(normal).WaitAsync(ShortTimeout);
(await recvTask).Should().Equal(normal);
Expand Down