fix(sections-editor): stop Add variant button overlapping field controls - #7254
Merged
Merged
Conversation
The multivariate "Add variant" flag was absolutely positioned at the top-right of the field it wraps. That is empty space for the common stacked field (label above input), but BooleanField lays out inline with its Switch pinned right, so the flag rendered on top of the toggle — covering it and stealing its clicks. Give the button its own gutter column instead of overlaying, and render it after the field so focus order is input -> Add variant. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same change as #7156, pushed to an in-repo branch so CI secrets (GITLEAKS_LICENSE, Docker Hub creds for the e2e MinIO pull) are available — fork PRs don't get repo secrets, which is why the checks failed there.
Original author: @vitoUwu
Supersedes #7156
🤖 Generated with Claude Code
Summary by cubic
Stops the sections editor's "Add variant" button from overlapping field controls. The button was absolutely positioned on top of the field, which worked for stacked layouts but covered BooleanField's inline switch and blocked its clicks; it now sits in its own grid column and renders after the field so tab order goes input → Add variant.
Written for commit c093378. Summary will update on new commits.