Conversation
Remove the five AbacusDevice_t-keyed memory wrappers and their tests; they have no call site in the tree or in the history. Refs deepmodeling#8039
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Removes unused runtime-device memory wrappers while retaining compile-time *_op templates.
Changes:
- Removed wrapper declarations, implementations, and explicit instantiations.
- Removed the obsolete
tool_quit.hinclude. - Removed tests for the deleted wrapper API.
| File | Description |
|---|---|
source/source_base/module_device/test/memory_test.cpp |
Removes tests for deleted wrappers. |
source/source_base/module_device/memory_op.h |
Removes runtime wrapper declarations. |
source/source_base/module_device/memory_op.cpp |
Removes wrapper implementations and instantiations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mohanchen
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fix #8039
What's changed?
Delete the five
AbacusDevice_t-keyed wrappers (resize_memory, set_memory, synchronize_memory, cast_memory, delete_memory). They have no call site in the tree or anywhere in the history, and their runtime device dispatch duplicated the compile-time*_optemplates, which is why the defective `||` conditions behind #7553 went unnoticed.Also drop #7941's explicit instantiations, the then-unused
tool_quit.hinclude, and the dispatch tests that exercised the removed API. The*_opstruct templates are untouched.