Add configurable torch-latest dependency versions - #8016
Merged
tohtana merged 11 commits intoMay 20, 2026
Conversation
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
There was a problem hiding this comment.
💡 Codex Review
Preserve selected Transformers version in CPU workflow
If a manual run selects transformers_source=pypi with a version below 4.51.3 (including the new default 4.50.0), this later install command pulls in the dev extra and upgrades Transformers to satisfy requirements/requirements-dev.txt (transformers>=4.51.3). That silently overrides the version chosen in the new input, so the workflow no longer validates the requested package version.
Keep AWS full run on the user-selected Transformers build
In manual runs using transformers_source=pypi, the explicit install done earlier can be undone here because requirements/requirements-dev.txt requires transformers>=4.51.3. Any selected lower version (for example the new default 4.50.0) will be upgraded, so the workflow reports a successful run without actually testing the requested Transformers version.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Collaborator
Author
|
Addressed the comments @codex |
|
To use Codex here, create an environment for this repo. |
Merged
PKUWZP
self-requested a review
May 20, 2026 05:46
PKUWZP
approved these changes
May 20, 2026
frozenleaves
pushed a commit
to frozenleaves/DeepSpeed
that referenced
this pull request
Jun 8, 2026
## Summary The modal test now shows the error because of the combination of PyTorch v2.7 and Transformer `main` branch, and it is blocking PRs. To address it, we improve our test workflows as follows. - Add manual dependency version inputs for the torch-latest CI workflows and default the torch-latest family to PyTorch 2.10 plus Transformers git `main`. - Let CPU and AWS full torch-latest runs select either released Transformers package versions or an explicit Transformers git ref for manual validation. - Let Modal torch-latest runs select supported PyTorch/CUDA image presets and an optional Transformers git ref, defaulting to `2.10.0-cuda12.8` and Transformers git `main`. ## Known follow-up - The AWS full real CI lane for PyTorch 2.10 plus Transformers main reached `Unit tests (parallel)` but failed with 33 failures. Some of these may overlap with fixes in deepspeedai#8015; I am opening this PR now so the workflow/input changes can be reviewed while those failures are handled separately. - CPU and Modal real CI validation for the requested tuple passed. --------- Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
nathon-lee
pushed a commit
to nathon-lee/DeepSpeed_woo
that referenced
this pull request
Jul 1, 2026
## Summary The modal test now shows the error because of the combination of PyTorch v2.7 and Transformer `main` branch, and it is blocking PRs. To address it, we improve our test workflows as follows. - Add manual dependency version inputs for the torch-latest CI workflows and default the torch-latest family to PyTorch 2.10 plus Transformers git `main`. - Let CPU and AWS full torch-latest runs select either released Transformers package versions or an explicit Transformers git ref for manual validation. - Let Modal torch-latest runs select supported PyTorch/CUDA image presets and an optional Transformers git ref, defaulting to `2.10.0-cuda12.8` and Transformers git `main`. ## Known follow-up - The AWS full real CI lane for PyTorch 2.10 plus Transformers main reached `Unit tests (parallel)` but failed with 33 failures. Some of these may overlap with fixes in deepspeedai#8015; I am opening this PR now so the workflow/input changes can be reviewed while those failures are handled separately. - CPU and Modal real CI validation for the requested tuple passed. --------- Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com> Signed-off-by: nathon-lee <leejianwoo@gmail.com>
nathon-lee
pushed a commit
to nathon-lee/DeepSpeed_woo
that referenced
this pull request
Jul 1, 2026
## Summary The modal test now shows the error because of the combination of PyTorch v2.7 and Transformer `main` branch, and it is blocking PRs. To address it, we improve our test workflows as follows. - Add manual dependency version inputs for the torch-latest CI workflows and default the torch-latest family to PyTorch 2.10 plus Transformers git `main`. - Let CPU and AWS full torch-latest runs select either released Transformers package versions or an explicit Transformers git ref for manual validation. - Let Modal torch-latest runs select supported PyTorch/CUDA image presets and an optional Transformers git ref, defaulting to `2.10.0-cuda12.8` and Transformers git `main`. ## Known follow-up - The AWS full real CI lane for PyTorch 2.10 plus Transformers main reached `Unit tests (parallel)` but failed with 33 failures. Some of these may overlap with fixes in deepspeedai#8015; I am opening this PR now so the workflow/input changes can be reviewed while those failures are handled separately. - CPU and Modal real CI validation for the requested tuple passed. --------- Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The modal test now shows the error because of the combination of PyTorch v2.7 and Transformer
mainbranch, and it is blocking PRs. To address it, we improve our test workflows as follows.main.2.10.0-cuda12.8and Transformers gitmain.Known follow-up
Unit tests (parallel)but failed with 33 failures. Some of these may overlap with fixes in Run FastFileWriter fd-close test outside pytest-forked #8015; I am opening this PR now so the workflow/input changes can be reviewed while those failures are handled separately.