[AutoTP] Preserve universal checkpoint metadata for HuggingFace tp_plan - #8187
Merged
Conversation
Contributor
Author
|
@delock I have cleaned up the dependency relationships. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77357273d9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
delock
approved these changes
Jul 29, 2026
delock
enabled auto-merge
July 29, 2026 08:40
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 29, 2026
Attach universal checkpoint metadata after applying a HuggingFace tp_plan, keeping this path consistent with custom and heuristic AutoTP. Signed-off-by: iLeGend <824040212@qq.com>
Signed-off-by: iLeGend <824040212@qq.com>
Signed-off-by: iLeGend <824040212@qq.com>
Contributor
Author
|
updated: #8146 merged, so add corresponding test |
delock
enabled auto-merge
July 30, 2026 05:26
banxingmjj
pushed a commit
to openanolis/DeepSpeed
that referenced
this pull request
Jul 30, 2026
…UDE.md (deepspeedai#8194) <img width="521" height="277" alt="image" src="https://github.com/user-attachments/assets/93ddcc79-6eb3-41cf-828e-898ff8dfac8b" /> Try to avoid deepspeedai#8187 (comment), please directly close it if not necessary. --------- Signed-off-by: iLeGend <824040212@qq.com> Co-authored-by: Ma, Guokai <guokai.ma@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attach AutoTP universal checkpoint metadata before returning from a successfully converted HuggingFace
tp_plan.Previously, this path replaced modules and returned without preserving the metadata required by
ds_to_universal, unlike custom-config and heuristic AutoTP paths.Testing
Add coverage for:
colwiserowwisecolwise_gather_output(Due to [AutoTP] Enable HFcolwise_gather_outputto supportlm_headreplace #8146 merged)