Add UpdateTypes field to Allowed struct - #605
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds update-types support to the allow block of dependabot.yml by extending the CLI job model, aligning it with the existing ignore-conditions (Condition.UpdateTypes) pattern used elsewhere in the Dependabot CLI.
Changes:
- Add
UpdateTypes []stringtomodel.Allowedwithjson/yaml:"update-types,omitempty"tags. - Extend the
exampleJobYAML fixture with anallowed-updatesentry that usesupdate-types. - Add YAML unmarshal and JSON-focused tests for
Allowed.UpdateTypes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/model/job.go | Extends the job model (Allowed) to carry update-types through to the updater payload. |
| internal/model/job_test.go | Updates fixtures and adds tests to cover YAML parsing and JSON handling for the new field. |
v-kbukum1
force-pushed
the
kbukum1/allow-update-types
branch
from
March 27, 2026 16:44
9111723 to
ebe3572
Compare
truggeri
previously approved these changes
Mar 27, 2026
truggeri
left a comment
There was a problem hiding this comment.
Good by me, but I do think the marshal test could be slightly better.
Add update-types support to the Allowed struct, matching the existing pattern in the Condition (ignore) struct. This enables semver-level filtering (major/minor/patch) in allow blocks of dependabot.yml. Changes: - Add UpdateTypes []string field to Allowed struct in model/job.go - Add update-types entry to exampleJob YAML fixture - Add TestAllowedUpdateTypes: verifies YAML unmarshal of update-types - Add TestAllowedUpdateTypesJSON: verifies JSON round-trip serialization Relates to dependabot/dependabot-core#12668. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Unmarshal into map[string]any to verify correct JSON tag names
("update-types", "dependency-name") rather than round-tripping
through the same struct. Also verify omitempty behavior.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Compare marshaled JSON string directly to verify correct key names and omitempty behavior, per reviewer feedback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
v-kbukum1
force-pushed
the
kbukum1/allow-update-types
branch
from
March 27, 2026 18:37
a7054d9 to
1050006
Compare
Contributor
Author
@truggeri |
5 tasks done
Merged
5 tasks done
This was referenced Sep 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
UpdateTypes []stringfield to theAllowedstruct, enablingupdate-typessupport in theallowblock ofdependabot.yml.This matches the existing pattern in the
Condition(ignore) struct which already hasUpdateTypes []stringat line 221.Changes
internal/model/job.go: AddUpdateTypes []stringfield toAllowedstruct withjson:"update-types,omitempty" yaml:"update-types,omitempty"tagsinternal/model/job_test.go: Addupdate-typestoexampleJobfixture, addTestAllowedUpdateTypes(YAML unmarshal) andTestAllowedUpdateTypesJSON(JSON round-trip) testsRelated PRs
update-typesinallowblock dependabot-core#12925 (updater logic)Relates to dependabot/dependabot-core#12668.