This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Update: type hints for functions - #14
Closed
yankeexe wants to merge 2 commits into
Closed
Conversation
yankeexe
force-pushed
the
update-type-hints
branch
from
April 15, 2021 13:10
9f1e0ec to
50617a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated type hints for the functions.
Few things I would like to get confirmed before I make the changes:
Reference: mypy Standard Duck Types
dictwithtyping.Mappingandtyping.MutableMapping.listandListwithtyping.Iterableandtyping.Sequence.I believe these changes will make the code more predictable.