This repository was archived by the owner on Oct 22, 2024. It is now read-only.
chore(ref): Improve Codebase and Refactor some functions - #68
Closed
yezz123 wants to merge 1 commit into
Closed
Conversation
eriwiana
reviewed
Jan 8, 2023
| return res | ||
| elif code == 409: | ||
| raise Exception("Item with key '{4}' already exists".format(key)) | ||
| raise ValueError("Item with key '{4}' already exists".format(key)) |
There was a problem hiding this comment.
I think this one should be changed into f-string too
Suggested change
| raise ValueError("Item with key '{4}' already exists".format(key)) | |
| raise ValueError(f"Item with key '{key}' already exists") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed:
if/elsebranches ofifexpression to remove negationif statementwith if the expressiona little improvement in the codebase could help to refactor and performance for the upcoming functions in Deta client.