Skip to content

Fix for unused type in new ethers-v5 codegen - #776

Closed
iainnash wants to merge 4 commits into
dethcrypto:masterfrom
iainnash:iain/fix-721-promise-or-value-issue-typescript
Closed

Fix for unused type in new ethers-v5 codegen#776
iainnash wants to merge 4 commits into
dethcrypto:masterfrom
iainnash:iain/fix-721-promise-or-value-issue-typescript

Conversation

@iainnash

Copy link
Copy Markdown
Contributor

Fixes #721

@changeset-bot

changeset-bot Bot commented Sep 27, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2e62cee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@typechain/ethers-v5 Patch
@typechain/hardhat Patch
test-e2e Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joewagner

Copy link
Copy Markdown

I'm running into an build error. error TS6196: 'PromiseOrValue' is declared but never used.
As far as I can tell this PR would fix the issue. Any plans to merge and publish this?

@krzkaczor

Copy link
Copy Markdown
Member

@iainnash can you fix CI problems?

@iainnash

iainnash commented Jan 18, 2023 via email

Copy link
Copy Markdown
Contributor Author

@yorhodes

yorhodes commented Apr 21, 2023

Copy link
Copy Markdown

@iainnash @krzkaczor anything I can do to get this merged?

@krzkaczor

Copy link
Copy Markdown
Member

@iainnash thanks for this fix and sorry that it took so long to ship.

@krzkaczor krzkaczor closed this May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unused type in new release

4 participants