Repository navigation
refactor: centralize url construction - #1
Merged
Merged
Conversation
…rmalizat Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…ility covering all edge cases Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…se URL utility Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…tility for image proxy URLs
Created comprehensive verification program and report for URL utility edge cases. - Created backend/cmd/url-verify/main.go verification program - Tests 8 different BASE_URL configurations (trailing slash, no slash, port, subpath, etc.) - Verifies 5 real-world use cases (email, password reset, invites, release pages, image proxy) - Validates 3 edge case checks (no double slashes, protocol present, no trailing slash) - All 64 test cases passed (100% success rate) - Created detailed verification report documenting all results Verified configurations: ✓ With/without trailing slash ✓ With/without protocol ✓ With port numbers ✓ With subpaths ✓ Complex combinations (port + subpath + trailing slash) ✓ Localhost special handling (http vs https) All acceptance criteria met. Ready for production. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
devbydaniel
added a commit
that referenced
this pull request
Jan 31, 2026
…e config, fix race condition (qa-requested) Fixes: - Issue #1: Fixed inverted cost calculation formula (PublicMaxTokens / PublicRequestsPerInterval) - Issue #2: Cache config in init() instead of creating on every request - Issue #3: Add mutex to protect buckets map from concurrent access - Issue #4: Add config validation for rate limit values Verified: - Cost calculation now correctly limits requests to configured value - Config loaded only once at startup instead of per-request - Map access protected with sync.RWMutex and double-check pattern - Invalid config values (<=0) will panic at startup with clear error QA Fix Session: 1 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit and fix all URL construction and parsing logic across the codebase. Standardize URL handling with a utility module that correctly handles base URLs, trailing slashes, and protocol prefixes.