feat(hub-ui): raise the recent dock out of the float bar's overflow - #305
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In float mode, a dock selected from beyond the bar — the overflow popover or a dock group — is now raised into a dedicated recent dock slot between the bar's visible items and the overflow button. Deselecting it (or selecting a visible neighbour) keeps it there, one click away, instead of folding it straight back out of reach.
With a 3-slot bar over entries A–E:
[A] [B] [C] | [Overflow]— select D from the popover →[A] [B] | {D} [Overflow][A] {B} | [D] [Overflow][A] [B] | {E} [Overflow][A] [B] {C} | [Overflow]The recent slot consumes one of
maxVisibleItems, the raised entry is lifted out of the overflow popover (badge follows), and a grouped member is always raised on selection — its own entry never has a rail slot of its own. The id persists per-tab asrecentDockIdon the existingdevframes-dock-sessionsessionStorage store, so it survives reloads.How
@devframes/hub:DockSessionStoragegains an optionalrecentDockId.@devframes/hub-uidock-settings.ts:docksSplitGroupsWithCapacityaccepts a resolved recent entry and reserves its slot (skipped when there's no overflow, or when the recent entry sits inside the natural visible slice — it renders in place there, releasing the slot); new pure helpersresolveRecentDockEntry(persisted id → raisable entry, dropping unregistered/hidden ones) andresolveNextRecentDockId(the selection rule).Dock.vuerenders the recent slot and updatesrecentDockIdby watching the selection, so palette / RPC / restore selections behave the same as rail clicks.WithRecentDockstory shows the slot live (behavior also verified interactively in Storybook).Created with the help of an agent.