Temporarily remove compilation check for Absinthe#24
Conversation
Assertions conditionally adds helpers for use with Absinthe. `Assertions.Absinthe` utilizes `Code.ensure_compiled/1` to manage this condition. However, `undefined function assert_response_equals/4` is raised when compiling the all dependencies. Recompiling assertions after compiling all dependencies satisfies the call to `Code.ensure_compiled/1` and the exception is avoided. This removes the conditional check until a proper solution can be found and since we are using Absinthe.
|
@timgremore you saved me from hell... I've been drying myself nuts around this issue until I came up with your comments. |
|
hi @devonestes can we get this merged in soon? Did you need some help with that? |
|
Heads up, this is still an issue and would be really nice to get merged in. |
|
This is still a problem. I also think the docs make it clear that this is unnecessary: https://hexdocs.pm/elixir/Code.html#module-ensure_compiled-1-and-ensure_compiled-1 It would be useful to get this merged in; otherwise, we are having to maintain a fork. |
|
Any update? @devonestes |
|
So we were relying on this fork for literally years and it was recently deleted and our CI failed because of it. We couldn't build, we couldn't deploy, etc. At first I assumed that it was merged upstream, or that upstream contained a fix that made this fork unnecessary. Nope. As I've progressed through Ruby/JS dev to Elixir dev to Go dev... things have become more clear to me: do not pull in deps for things that you can write a single function or two for. |
Assertions conditionally adds helpers for use with Absinthe.
Assertions.AbsintheutilizesCode.ensure_compiled/1to manage thiscondition. However,
undefined function assert_response_equals/4is raisedwhen compiling all dependencies. Recompiling assertions after compiling all
dependencies satisfies the call to
Code.ensure_compiled/1and the exceptionis avoided. This removes the conditional check until a proper solution can be
found and since we are using Absinthe.
Issue is also described #22