add BIP341 to the threshold Schnorr rust example - #1071
Conversation
| k256::schnorr::Signature::try_from(sig_bytes).expect("failed to deserialize signature"); | ||
|
|
||
| let vk = k256::schnorr::VerifyingKey::from_bytes(&tweaked_pk_bytes) | ||
| .expect("failed to deserialize BIP340 encoding into public key"); |
There was a problem hiding this comment.
IIRC we can do the entire verification using secp256k1 here rather than having to use both k256 and secp256k.
There was a problem hiding this comment.
Alternately, with a bit more effort (copying the code from https://github.com/dfinity/ic/blob/master/rs/crypto/secp256k1/src/lib.rs#L352) we could do the verification using only k256 and avoid the bitcoin dependency. Given the apparent complications in the build that this brings in, it might be worthwhile.
There was a problem hiding this comment.
Removed k256.
Re removing bitcoin, there's also another aspect, which is complexity. I guess here, among other things, we want to show how simple it is to use threshold Schnorr. It's useful to show that it's perfectly fine to use the existing bitcoin crate with threshold Schnorr in a canister.
fspreiss
left a comment
There was a problem hiding this comment.
Re-approving because review was automatically dismissed
fspreiss
left a comment
There was a problem hiding this comment.
Re-approving because review was automatically dismissed
fspreiss
left a comment
There was a problem hiding this comment.
Re-approving because review was automatically dismissed
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
|
Oh, approvals are reset even if I only apply suggestions from the PR via the github UI. That's quite extreme... |
fspreiss
left a comment
There was a problem hiding this comment.
Re-approving because review was automatically dismissed
No description provided.