Skip to content

Formatting#19

Merged
bhourahine merged 5 commits into
dftbplus:masterfrom
aradi:formatting
Oct 22, 2021
Merged

Formatting#19
bhourahine merged 5 commits into
dftbplus:masterfrom
aradi:formatting

Conversation

@aradi

@aradi aradi commented Sep 20, 2021

Copy link
Copy Markdown
Member

Implements advance formatting.

Note, it is based on PR #18 , so that should be merged first. It fixes the capitalization issue mentioned in #6.

@aradi aradi force-pushed the formatting branch 2 times, most recently from c843ed0 to e249fb7 Compare September 20, 2021 20:27
@aradi

aradi commented Oct 1, 2021

Copy link
Copy Markdown
Member Author

@awvwgk This is ready now as well. Although it does not fix all issues yet, it provides a more robust framework as we had before, so IMO it would be worth to merge it in its current state.

@bhourahine bhourahine left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

equal -> equals in documentation and code (if UK English)

Comment thread docs/hsd.rst Outdated
Comment thread docs/hsd.rst Outdated
Comment thread docs/hsd.rst Outdated
Comment thread docs/hsd.rst Outdated
Comment thread docs/hsd.rst Outdated
Comment thread src/hsd/io.py Outdated
Comment thread src/hsd/io.py Outdated
Comment thread src/hsd/parser.py Outdated
Comment thread src/hsd/parser.py Outdated
Comment thread test/test.hsd
aradi and others added 2 commits October 1, 2021 17:36
@aradi

aradi commented Oct 1, 2021

Copy link
Copy Markdown
Member Author

@bhourahine Sorry for the tons of typos and misspellings & many thanks for correcting them. I've made all the suggested changes.

@awvwgk awvwgk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bhourahine bhourahine merged commit 78146c0 into dftbplus:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants