Skip to content

ci: remove labeler and simplify change detection - #9751

Merged
matthewmcneely merged 2 commits into
mainfrom
matthewmcneely/perform-ci-hygiene
Jun 18, 2026
Merged

matthewmcneely merged 2 commits into
mainfrom
matthewmcneely/perform-ci-hygiene

Conversation

@matthewmcneely

Copy link
Copy Markdown
Contributor

Description

Created detect-changes.yml with centralized skip patterns and refactored all 8 workflows:

  • New workflow (detect-changes.yml): Uses dorny/paths-filter and centralizes skip patterns in one place (docs, images, contrib, various asset extensions)
  • Updated 8 workflows: All now call detect-changes and use needs.changes.outputs.code == 'true' instead of the previous should-skip flag
  • Deleted the old check-changes.yml

Benefits:

  • Skip patterns defined once, not scattered across 8 workflows
  • Cleaner PR status checks (no intermediate check-changes job)
  • More robust change detection via dorny/paths-filter vs shell script
  • Same functionality, less overhead

Commits: e3aa1fb (removed labeler) and 9db1fec6f (consolidated change detection)

Checklist

Analysis of merged PRs over the last 6 months shows the labeler only applied
labels to 67% of PRs (37 of 55). The 33% unlabeled rate combined with missing
labels on PRs that clearly matched the rules indicates the workflow was not
providing sufficient value to maintain. Removes both the workflow and label
configuration.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@matthewmcneely
matthewmcneely requested a review from a team as a code owner June 18, 2026 16:41
Remove the ineffective labeler workflow (only applied labels to 67% of PRs
over 6 months). Replace the reusable check-changes workflow with a new
detect-changes workflow using dorny/paths-filter. This centralizes skip
patterns in one place and reduces workflow output clutter.

All 8 dependent workflows (core, fuzz, integration2, ldbc, load, systest,
arm64, vector) now call detect-changes directly.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@matthewmcneely
matthewmcneely force-pushed the matthewmcneely/perform-ci-hygiene branch from 6bcd59f to c996d47 Compare June 18, 2026 17:02
@matthewmcneely
matthewmcneely merged commit 4309b87 into main Jun 18, 2026
18 checks passed
@matthewmcneely
matthewmcneely deleted the matthewmcneely/perform-ci-hygiene branch June 18, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant