Repository navigation
chore(deps): bump golang.org/x/text from 0.37.0 to 0.39.0 - #9798
Merged
Merged
Conversation
Fixes GO-2026-5970 (infinite loop on invalid input in x/text), which govulncheck reports as reachable from language-aware sorting (types.SortWithFacet) and fulltext stopword filtering. Lifts the rest of the golang.org/x family as MVS side effects, including x/net 0.56.0 (clears module-level GO-2026-5942). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps
golang.org/x/textfrom 0.37.0 to 0.39.0 to fix GO-2026-5970, an infinite loop on invalid input in the normalization code. govulncheck reports the vulnerable symbols as reachable in the shipped binary through two user-facing paths: language-aware sorting (types.SortWithFacetviacollate.New) and fulltext stopword filtering (tok.filterStopwordsvia the unicode normalize filter). Both operate on user-supplied data, so a crafted input could pin a goroutine at 100% CPU.The
go getalso lifts the rest of thegolang.org/xfamily through minimum version selection (x/net0.56.0,x/crypto0.53.0,x/sys,x/mod,x/sync,x/term,x/tools). Thex/netbump incidentally clears the module-level GO-2026-5942 finding as well.Verified with
go test ./types/... ./tok/...(the packages on the reachable paths).Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.