Skip to content

test against couch 2 - #26

Merged
snopoke merged 8 commits into
dimagi:jsonobjectfrom
emord:je/couch-2
Nov 17, 2017
Merged

test against couch 2#26
snopoke merged 8 commits into
dimagi:jsonobjectfrom
emord:je/couch-2

Conversation

@emord

@emord emord commented Nov 9, 2017

Copy link
Copy Markdown
Contributor

Realized we've never actually tested this on couch 2. Here's some fun failures:

reason":"all_or_nothing is not supported"}
Unauthorized: {"error":"forbidden","reason":"Temporary views are not supported in CouchDB"}
PreconditionFailed: The database could not be created, the file already exists.

@dannyroberts @snopoke

@emord emord mentioned this pull request Nov 9, 2017
@snopoke

snopoke commented Nov 10, 2017

Copy link
Copy Markdown
Contributor

What's your plan for this? Do you think it's necessary to make this whole library work with couch2?

@emord

emord commented Nov 10, 2017

Copy link
Copy Markdown
Contributor Author

No. I plan on just ripping out the parts that don't work in couch 2, since we don't use that anymore (except swiss, which should get moved at some point)

I plan on working on #24 for the hackathon and realized that I had removed some tests there because they don't actually work in couch 2

@emord

emord commented Nov 10, 2017

Copy link
Copy Markdown
Contributor Author

Ripped out stuff that's specific to couch 1, and fixed some tests.

There's a doc folder that looks autogenerated. guessing it powered (now defunct) couchdbkit.org. There aren't any docs about generating the docs. should we kill that folder too?

@snopoke snopoke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question about a test

Comment thread tests/client_test.py

del self.Server['couchdbkit_test']

def testMultipleDocCOnflict(self):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's wrong with this test? Seems like it's just the last bit that should be removed (with all_or_nothing)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point 8544e94

@emord

emord commented Nov 17, 2017

Copy link
Copy Markdown
Contributor Author

I think this is good to go

@snopoke
snopoke merged commit f7f8e2d into dimagi:jsonobject Nov 17, 2017
@emord emord mentioned this pull request Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants