remove prefix 'W/"' from _rev - #43
Merged
Merged
Conversation
added 2 commits
July 11, 2018 16:36
emord
reviewed
Jul 12, 2018
| raise ResourceNotFound | ||
| raise | ||
| return response.headers['ETag'].strip('"') | ||
| return response.headers['ETag'].strip('"').strip('W/"') |
Contributor
There was a problem hiding this comment.
Where is the W/" coming from?
Contributor
Author
There was a problem hiding this comment.
Never figured out exactly where. I assume that the cloudant api sends a slightly different request.
added 2 commits
July 12, 2018 13:29
emord
approved these changes
Jul 12, 2018
Contributor
|
Interesting that couch returns a weak etag |
Contributor
|
@snopoke yeah. it's weird and looks like it only happens on our self hosted instances. I quickly looked through the couch docs, but didn't see anywhere that that could be changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address https://sentry.io/dimagi/commcarehq/issues/605853916/