Skip to content

raise ResourceNotFound when trying to delete an already deleted doc #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickpell merged 2 commits into from
Jul 16, 2018
Merged

raise ResourceNotFound when trying to delete an already deleted doc #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9167e4e
raise ResourceNotFound when trying to delete an already deleted doc
Jul 16, 2018
6df4106
bump version
Jul 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions couchdbkit/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,10 +726,7 @@ def delete_doc(self, doc, **params):
couch_doc['_rev'] = doc1['_rev']
elif isinstance(doc1, six.string_types): # we get a docid
couch_doc = Document(self.cloudant_database, doc1)
try:
couch_doc['_rev'] = self.get_rev(doc1)
except ResourceNotFound:
raise ResourceConflict
couch_doc['_rev'] = self.get_rev(doc1)

# manual request because cloudant library doesn't return result
res = self._request_session.delete(
Expand Down
2 changes: 1 addition & 1 deletion couchdbkit/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@

from __future__ import absolute_import
from six.moves import map
version_info = (0, 9, 0, 3, 7)
version_info = (0, 9, 0, 3, 8)
__version__ = ".".join(map(str, version_info))