ata: Implement DMA transfers - #192
Merged
Merged
Conversation
dingusdev
requested changes
Jul 12, 2026
dingusdev
left a comment
Owner
There was a problem hiding this comment.
The implementation of push_data should be its own commit.
Other than that, this looks good.
Implement push_data in AtaBaseDevice using the device transfer buffer and post-transfer callback. Advance the read data pointer across DMA pulls so a transfer can span multiple DBDMA descriptors, and clear the DMA state when transfers finish.
Add read/write DMA command support to ATA hard disks (can mostly reuse the PIO paths).
mihaip
force-pushed
the
upstream-ata-dma-take2
branch
from
July 12, 2026 00:46
7776eb2 to
017a4a4
Compare
mihaip
added a commit
to mihaip/infinite-mac
that referenced
this pull request
Jul 12, 2026
Also includes the fix from dingusdev/dingusppc#192 which allows the Mac OS X public beta to boot. For #219
dingusdev
pushed a commit
that referenced
this pull request
Aug 16, 2026
Followup to #192. That implemented DMA support, but did not advertise it via the IDENTIFY command. While the 10.0 public beta used it unconditionally, later releases will only use it if the hardware reports the MWDMA bit. Takes booting 10.3 (to WindowServer startup) from ~60 seconds to ~47 seconds on my machine.
mihaip
added a commit
to mihaip/dingusppc
that referenced
this pull request
Aug 22, 2026
With dingusdev#214 we started to advertise the IDE DMA support from dingusdev#192 to guests. That appeared to break booting Mac OS 8.x, at least on the Beige G3: the startup disk was not even detected. Mac OS 8.1 sets up an IDE DMA read as INPUT_MORE, then a NOP with its i field set to always, then STOP, which clears the channel's ACTIVE bit. The emulated transfer completion path interpreted only one following descriptor, so it stopped at NOP. NOP raised the interrupt, but STOP was never reached and the channel stayed active. The Mac OS X driver is more tolerant of this, which is why it was not an issue there. The DBDMA Specification, section 1.4, says: "The target fetches command entries and performs the command-entry-specified data-transfer operation, processing command entries until a STOP entry is reached". Keep interpreting ready commands until a transfer blocks or the channel stops, as start() and resume() already did. This is closer to the hardware behavior, and empirically lets Mac OS 8.1 boot again.
dingusdev
pushed a commit
that referenced
this pull request
Aug 22, 2026
With #214 we started to advertise the IDE DMA support from #192 to guests. That appeared to break booting Mac OS 8.x, at least on the Beige G3: the startup disk was not even detected. Mac OS 8.1 sets up an IDE DMA read as INPUT_MORE, then a NOP with its i field set to always, then STOP, which clears the channel's ACTIVE bit. The emulated transfer completion path interpreted only one following descriptor, so it stopped at NOP. NOP raised the interrupt, but STOP was never reached and the channel stayed active. The Mac OS X driver is more tolerant of this, which is why it was not an issue there. The DBDMA Specification, section 1.4, says: "The target fetches command entries and performs the command-entry-specified data-transfer operation, processing command entries until a STOP entry is reached". Keep interpreting ready commands until a transfer blocks or the channel stops, as start() and resume() already did. This is closer to the hardware behavior, and empirically lets Mac OS 8.1 boot again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add read/write DMA support to ATA devices (mostly reusing existing PIO read and write paths).
We also need to advance
data_ptracross DMA pulls so transfers can span multiple DBDMA descriptors.Fixes #154