fix: protect active Markdown original during PDF export - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting the open Markdown document as the PDF export destination replaced its source bytes with a PDF. Export now rejects the original document and its path/file aliases before rendering and again immediately before publication. The original export source remains protected if the active file changes during the operation; confirmed replacement of an ordinary PDF still works.
Validation: six failing regression cases before the fix; full suite 234 passed / 1 Windows symlink privilege skip; whole-project Ruff and diff checks passed; Windows self-test exit 0. Independent tests cover native parent junctions, aliases introduced after real Qt printing, final-guard permission failures, automatic first-save originals, and ordinary PDF replacement.
The final identity check does not provide a filesystem-wide transaction against an external change between that check and replacement. Product version and installed/Store builds are unchanged.