Repository navigation
ci: verify Flutter and cover source smoke runtime inputs - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flutter analysis and widget tests were absent from CI, while source-smoke triggers missed translation, asset, metadata and workflow changes. Add a pinned Flutter job that resolves the existing lockfile, runs analysis and tests, and expand Linux/macOS source-smoke triggers to cover the runtime inputs.
The current static web companion has no npm test package. Its eight existing Python contract tests already run in the full desktop CI; document that actual contract and its browser-testing limits instead of adding an obsolete npm command. SDK and action references are recorded in docs/CI-CONTRACT.md.
Validation at f633c1f: actual Flutter 3.47.5 / Dart 3.13.4 lockfile resolution passed, analysis reported no issues, and all 37 Flutter tests passed. All eight Python matrix jobs, both Linux/macOS source-smokes and all three CodeQL analyses succeeded. actionlint 1.7.12, ten local web/source-smoke isolation tests, native 6/6 source-smoke and diff checks passed; final independent review accepted.
Existing pubspec.yaml and pubspec.lock remain unchanged. SDK selection matches their locked packages; --enforce-lockfile remains mandatory and subsequent commands use --no-pub. No product version, installed build or Store changes. Browser and Android/iOS device acceptance remain separate from this CI contract.