Skip to content

Add killSessions command tests#593

Merged
eerxuan merged 23 commits into
documentdb:mainfrom
alinaliBQ:killSessions
Jul 6, 2026
Merged

Add killSessions command tests#593
eerxuan merged 23 commits into
documentdb:mainfrom
alinaliBQ:killSessions

Conversation

@alinaliBQ

@alinaliBQ alinaliBQ commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This change adds tests for the killSessions command operator.

Add command operator tests for killSessions. Tests database killSessions behavior, output collection, syntax, and expected errors.

@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jun 10, 2026
@documentdb-triage-tool

documentdb-triage-tool Bot commented Jun 10, 2026

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status In Progress
Confidence: 0.85 (mixed)

Reasoning

component from path globs (test-coverage, test-framework); effort from diff stats (1234+0 LOC, 9 files); LLM: Adds new test coverage for the $killSessions command operator, covering behavior, output, syntax, and error cases across multiple test scenarios.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@alinaliBQ alinaliBQ marked this pull request as ready for review June 10, 2026 23:59
@alinaliBQ alinaliBQ requested a review from a team as a code owner June 10, 2026 23:59
@alinaliBQ alinaliBQ changed the title Add $killSessions command tests Add killSessions command tests Jun 11, 2026
Rishabh998
Rishabh998 reviewed Jun 11, 2026
View reviewed changes
Comment thread ...ntdb_tests/compatibility/tests/core/sessions/commands/killSessions/test_killSessions_core.py Outdated
Comment thread ...ests/compatibility/tests/core/sessions/commands/killSessions/test_killSessions_acceptance.py
alinaliBQ
alinaliBQ commented Jun 11, 2026
View reviewed changes

@alinaliBQ alinaliBQ left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rishabh998 addressed comments

Comment thread ...ests/compatibility/tests/core/sessions/commands/killSessions/test_killSessions_acceptance.py
Comment thread ...ntdb_tests/compatibility/tests/core/sessions/commands/killSessions/test_killSessions_core.py Outdated
Comment thread ...ests/compatibility/tests/core/sessions/commands/killSessions/test_killSessions_acceptance.py
alinaliBQ added 16 commits July 2, 2026 15:28
@alinaliBQ
initially generated tests
9b0f828 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
inline random uuid generation
c018a75 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add missing tests from spec and merge files
75da8f7 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
remove duplicate tests
18c1a5f 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
convert to use CommandTestCase
808e516 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
Trigger CI
7e2e66d 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
mark killsessions tests as no_parallel to avoid flakes
4f453bd 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
Trigger CI
1459721 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
use non-existent uuid for killSessions
f0b5815 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add test_killSessions_real_session
d91c559 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
Trigger CI
ce0256c 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
apply comments from other PR s
22d09ce 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
remove out of scope test
6d7e5d5 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
use non-existent UUID instead of zeros
2842055 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
change test_killSessions_real_session to check real session kill
88b27a8 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
mark killSession tests as no_parallel
b813e84 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
alinaliBQ added 2 commits July 2, 2026 15:28
@alinaliBQ
update paths
1a406c2 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
fix isort
b5a08be 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
alinaliBQ added 3 commits July 2, 2026 16:00
@alinaliBQ
fix readconcern_afterclustertime_valid_timestamp
4a9e16f 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add clean up in test_killSessions_real_session
779a466 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add no_parallel
6402f0e 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
alinaliBQ
alinaliBQ commented Jul 2, 2026
View reviewed changes

@alinaliBQ alinaliBQ left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed comment

Comment thread ...ntdb_tests/compatibility/tests/core/sessions/commands/killSessions/test_killSessions_core.py Outdated
@alinaliBQ
Trigger CI
01752c1 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ alinaliBQ changed the title Add killSessions command tests Add killSessions command tests Jul 3, 2026
@eerxuan eerxuan merged commit 75810a4 into documentdb:main Jul 6, 2026
20 checks passed
krishnasai453 pushed a commit to krishnasai453/functional-tests that referenced this pull request Jul 8, 2026
@alinaliBQ @krishnasai453
Add killSessions command tests (documentdb#593)
c5dd02e 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
SarthakDalmia1 pushed a commit to SarthakDalmia1/functional-tests that referenced this pull request Jul 10, 2026
@alinaliBQ @sarthak-dalmia
Add killSessions command tests (documentdb#593)
6ed3414 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Sarthak Dalmia <sadalmia@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eerxuan eerxuan eerxuan approved these changes
+1 more reviewer
@Rishabh998 Rishabh998 Rishabh998 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alinaliBQ @Rishabh998 @eerxuan