Skip to content

Add removeQuerySettings tests#613

Merged
eerxuan merged 3 commits into
documentdb:mainfrom
alinaliBQ:removeQuerySettings
Jul 2, 2026
Merged

Add removeQuerySettings tests#613
eerxuan merged 3 commits into
documentdb:mainfrom
alinaliBQ:removeQuerySettings

Conversation

@alinaliBQ

@alinaliBQ alinaliBQ commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This change adds tests for the removeQuerySettings command operator. In order to define the SettingsTestCase class, I renamed query-planning to query_planning. Reason is that hyphens aren't allowed in identifiers, so directories that need to be imported must use underscores instead.

Add command operator tests for removeQuerySettings. Tests database removeQuerySettings behavior, output collection, syntax, and expected errors.

Edit: replica_set is needed because query settings are not supported on standalone instances

@alinaliBQ alinaliBQ marked this pull request as ready for review June 16, 2026 20:45
@alinaliBQ alinaliBQ requested a review from a team as a code owner June 16, 2026 20:45
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jun 16, 2026
@documentdb-triage-tool

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort XL · Status Needs Review
Confidence: 0.85 (mixed)

Reasoning

component from path globs (test-coverage, test-framework); effort from diff stats (1172+1 LOC, 25 files); LLM: Adds new test coverage for the removeQuerySettings command operator, touching test files within the compatibility tests component across multiple test scenarios.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@karthikvarma22

Copy link
Copy Markdown

I believe you will need to rebase this after #610 merge ?

@eerxuan eerxuan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and use @pytest.mark.requires(...)

@alinaliBQ alinaliBQ force-pushed the removeQuerySettings branch 2 times, most recently from 1a22cc1 to 9689101 Compare June 24, 2026 21:36
@alinaliBQ

Copy link
Copy Markdown
Contributor Author

@eerxuan I have rebased and used @pytest.mark.requires(change_streams=True)

@eerxuan eerxuan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts.

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ alinaliBQ force-pushed the removeQuerySettings branch from be41a02 to e821727 Compare June 25, 2026 18:11
@alinaliBQ

Copy link
Copy Markdown
Contributor Author

Yup, I have rebased and resolved the merge conflicts.

@eerxuan eerxuan merged commit d5ab71b into documentdb:main Jul 2, 2026
14 checks passed
krishnasai453 pushed a commit to krishnasai453/functional-tests that referenced this pull request Jul 8, 2026
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
SarthakDalmia1 pushed a commit to SarthakDalmia1/functional-tests that referenced this pull request Jul 10, 2026
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Sarthak Dalmia <sadalmia@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants