Skip to content

Add profile tests#621

Merged
eerxuan merged 3 commits into
documentdb:mainfrom
alinaliBQ:profile
Jun 25, 2026
Merged

Add profile tests#621
eerxuan merged 3 commits into
documentdb:mainfrom
alinaliBQ:profile

Conversation

@alinaliBQ

@alinaliBQ alinaliBQ commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add command operator tests for profile. Tests database profile behavior, output collection, syntax, and expected errors. Adds setup to DiagnosticTestCase. no_parallel is used for test cases that se level/rate/filters etc., because these are global settings that can impact other tests.

@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jun 17, 2026
@documentdb-triage-tool

documentdb-triage-tool Bot commented Jun 17, 2026

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status In Progress
Confidence: 0.85 (mixed)

Reasoning

component from path globs (test-coverage); effort from diff stats (1315+1 LOC, 11 files); LLM: Adds new test coverage for the profile command operator, including setup extensions to DiagnosticTestCase, touching test files within the compatibility tests component.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@alinaliBQ alinaliBQ marked this pull request as ready for review June 17, 2026 21:32
@alinaliBQ alinaliBQ requested a review from a team as a code owner June 17, 2026 21:32
@alinaliBQ
Add profile tests
e1892cc 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
address comment
48dc304 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
alinaliBQ
alinaliBQ commented Jun 24, 2026
View reviewed changes

@alinaliBQ alinaliBQ left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eerxuan rebased and addressed comments

Comment thread ...tests/compatibility/tests/system/diagnostic/commands/profile/test_profile_type_acceptance.py
Comment thread ...tests/compatibility/tests/system/diagnostic/commands/profile/test_profile_combined_params.py Outdated
@eerxuan eerxuan merged commit e481c16 into documentdb:main Jun 25, 2026
14 checks passed
RyanGarfinkel pushed a commit to RyanGarfinkel/functional-tests that referenced this pull request Jun 29, 2026
@alinaliBQ @RyanGarfinkel
Add profile tests (documentdb#621)
c8d8c35 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: RyanGarfinkel <113050972+RyanGarfinkel@users.noreply.github.com>
krishnasai453 pushed a commit to krishnasai453/functional-tests that referenced this pull request Jul 8, 2026
@alinaliBQ @krishnasai453
Add profile tests (documentdb#621)
7a38ed4 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
SarthakDalmia1 pushed a commit to SarthakDalmia1/functional-tests that referenced this pull request Jul 10, 2026
@alinaliBQ @sarthak-dalmia
Add profile tests (documentdb#621)
3d3f8b9 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Sarthak Dalmia <sadalmia@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eerxuan eerxuan eerxuan approved these changes
+1 more reviewer
@karthikvarma22 karthikvarma22 karthikvarma22 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alinaliBQ @karthikvarma22 @eerxuan