Skip to content

Add serverStatus tests#623

Merged
eerxuan merged 3 commits into
documentdb:mainfrom
alinaliBQ:serverStatus
Jun 25, 2026
Merged

Add serverStatus tests#623
eerxuan merged 3 commits into
documentdb:mainfrom
alinaliBQ:serverStatus

Conversation

@alinaliBQ

@alinaliBQ alinaliBQ commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Add command operator tests for serverStatus. Tests database serverStatus behavior, output collection, and syntax. There is no specific error code from serverStatus, since serverStatus is permissive to its inputs.

@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jun 18, 2026
@documentdb-triage-tool

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status In Progress
Confidence: 0.85 (mixed)

Reasoning

component from path globs (test-coverage); effort from diff stats (1029+0 LOC, 6 files); LLM: Adds new test coverage for the serverStatus command, covering behavior, output, syntax, and error cases — a functional enhancement to the test suite.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@alinaliBQ alinaliBQ marked this pull request as ready for review June 18, 2026 18:05
@alinaliBQ alinaliBQ requested a review from a team as a code owner June 18, 2026 18:05

@eerxuan eerxuan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Major] wiredTiger assertions violate the "no engine-specific implementation details" rule. TEST_COVERAGE.md:65 is explicit: "Don't test internal storage details (wiredTiger, engine-specific fields, etc.). These belong in engine-specific test suites, not compatibility tests." Three cases assert the wiredTiger section directly:

  • wiredTiger_is_object (response_structure) — asserts wiredTiger exists as an object
  • exclude_wiredTiger (field_toggle) — asserts it can be excluded

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ

Copy link
Copy Markdown
Contributor Author

@eerxuan wiredTiger_is_object and exclude_wiredTiger tests have been removed

@eerxuan eerxuan merged commit 05f89c5 into documentdb:main Jun 25, 2026
14 checks passed
RyanGarfinkel pushed a commit to RyanGarfinkel/functional-tests that referenced this pull request Jun 29, 2026
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: RyanGarfinkel <113050972+RyanGarfinkel@users.noreply.github.com>
krishnasai453 pushed a commit to krishnasai453/functional-tests that referenced this pull request Jul 8, 2026
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
SarthakDalmia1 pushed a commit to SarthakDalmia1/functional-tests that referenced this pull request Jul 10, 2026
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Sarthak Dalmia <sadalmia@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants