Add applyOps tests#624
Merged
Merged
Conversation
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (1233+0 LOC, 11 files); LLM: Adds new applyOps command test coverage and a new ReplicationTestCase class, expanding compatibility test suite across multiple test files within one component. If a label is wrong, remove it manually and ping |
karthikvarma22
approved these changes
Jun 22, 2026
eerxuan
reviewed
Jun 24, 2026
eerxuan
left a comment
Collaborator
There was a problem hiding this comment.
- 🟡 test_applyOps_core.py:581 & test_applyOps_multi_ops.py:1228 — use_admin is silently ignored by the doc-check functions.
Every case in APPLYOPS_DOC_CHECK_TESTS / APPLYOPS_MULTI_OPS_DOC_CHECK_TESTS sets use_admin=False, but these test functions call execute_command unconditionally and never read test.use_admin (unlike test_applyOps_core/_entry_validation/_multi_ops, which branch on it). A maintainer who later sets use_admin=True on a doc-check case would get no behavior change and no
warning. Either honor the flag or drop it from those cases.
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
…ck test Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
alinaliBQ
commented
Jun 24, 2026
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
eerxuan
approved these changes
Jun 25, 2026
RyanGarfinkel
pushed a commit
to RyanGarfinkel/functional-tests
that referenced
this pull request
Jun 29, 2026
krishnasai453
pushed a commit
to krishnasai453/functional-tests
that referenced
this pull request
Jul 8, 2026
SarthakDalmia1
pushed a commit
to SarthakDalmia1/functional-tests
that referenced
this pull request
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add command operator tests for applyOps, including the smoke test. Tests database applyOps behavior, output collection, syntax, and errors. Add the
ReplicationTestCaseclass definition.Add and use the
replicationcapability.