Skip to content

Add top tests#636

Merged
eerxuan merged 10 commits into
documentdb:mainfrom
alinaliBQ:top
Jul 2, 2026
Merged

Add top tests#636
eerxuan merged 10 commits into
documentdb:mainfrom
alinaliBQ:top

Conversation

@alinaliBQ

@alinaliBQ alinaliBQ commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add command operator tests for top. Tests database top behavior, output collection, syntax, and errors.
Adds setup field in DiagnosticTestCase.

@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jun 22, 2026
@documentdb-triage-tool

documentdb-triage-tool Bot commented Jun 22, 2026

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status In Progress
Confidence: 0.85 (mixed)

Reasoning

component from path globs (test-coverage); effort from diff stats (694+1 LOC, 7 files); LLM: Adds new test coverage for the top command operator, spanning behavior, output, syntax, and error cases within the compatibility test suite.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@alinaliBQ alinaliBQ marked this pull request as ready for review June 22, 2026 21:29
@alinaliBQ alinaliBQ requested a review from a team as a code owner June 22, 2026 21:29
eerxuan
eerxuan reviewed Jun 25, 2026
View reviewed changes
Comment thread documentdb_tests/compatibility/tests/system/diagnostic/commands/top/test_top_consistency.py Outdated
Comment thread documentdb_tests/compatibility/tests/system/diagnostic/commands/top/test_top_core_behavior.py Outdated
alinaliBQ added 7 commits June 25, 2026 11:14
@alinaliBQ
inital generated tests
34fb591 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
update from style guide
e65d04a 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
update with style guide
0c17d9b 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
remove duplicate test cases
8e5c027 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
convert to use DiagnosticTestCase
8544030 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add docs
1ef6445 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add test and fix format
71679e8 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add ns_data proper checks
3b8e887 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
alinaliBQ
alinaliBQ commented Jun 25, 2026
View reviewed changes

@alinaliBQ alinaliBQ left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed comments

Comment thread documentdb_tests/compatibility/tests/system/diagnostic/commands/top/test_top_consistency.py Outdated
Comment thread documentdb_tests/compatibility/tests/system/diagnostic/commands/top/test_top_core_behavior.py Outdated
@eerxuan eerxuan merged commit 9ce6d94 into documentdb:main Jul 2, 2026
20 checks passed
krishnasai453 pushed a commit to krishnasai453/functional-tests that referenced this pull request Jul 8, 2026
@alinaliBQ @krishnasai453
Add top tests (documentdb#636)
6f9546b 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
SarthakDalmia1 pushed a commit to SarthakDalmia1/functional-tests that referenced this pull request Jul 10, 2026
@alinaliBQ @sarthak-dalmia
Add top tests (documentdb#636)
d3b03c0 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Sarthak Dalmia <sadalmia@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eerxuan eerxuan eerxuan approved these changes

Assignees

No one assigned

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alinaliBQ @eerxuan