Add search stage tests#645
Merged
Merged
Conversation
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (9360+6 LOC, 40 files); LLM failed: Invalid response body while trying to fetch https://api.anthropic.com/v1/messages: Premature close If a label is wrong, remove it manually and ping |
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
tonglyu
reviewed
Jun 25, 2026
tonglyu
reviewed
Jun 26, 2026
tonglyu
reviewed
Jun 26, 2026
tonglyu
suggested changes
Jun 26, 2026
|
returnScope and searchNodePreference options are missing in the test |
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
|
…Source auth schema Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
tonglyu
approved these changes
Jul 2, 2026
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
eerxuan
reviewed
Jul 7, 2026
eerxuan
left a comment
Collaborator
There was a problem hiding this comment.
Please check the test failure, failed on retry.
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
eerxuan
approved these changes
Jul 9, 2026
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
The query_single_byte_run_over_cap and query_multi_byte_run_over_cap cases embedded multi-megabyte query strings directly in the parametrized test data, exceeding the 1,000,000-byte collection-time payload limit and failing test validation. Wrap the oversized query values in lazy(...) so they are built at test time instead of held in the collected data. Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
eerxuan
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for the
searchaggregation stage.The
mongotsidecar change here overlaps with #638. Both contain the same commit that should merge cleanly regardless of which is merged first.I defined a number of pytest fixtures to define the necessary indexed collections for these tests, as an index of this type is far more expensive to set up than the ones we use elsewhere (on the order of 30-60 secs). Using a module/package scoped fixture allows us to amortize this cost across the test cases rather than taking the hit each time.
Closes #374