Add $dateFromParts, $dateFromString, $dateToParts, $dateToString tests#678
Open
danielfrankcom wants to merge 6 commits into
Open
Add $dateFromParts, $dateFromString, $dateToParts, $dateToString tests#678danielfrankcom wants to merge 6 commits into
danielfrankcom wants to merge 6 commits into
Conversation
This change adds tests for the $dateFromParts expression. It was originally authored by @mitchell-elholm. Closes documentdb#306 Co-authored-by: Mitchell Elholm <mitchell-elholm@users.noreply.github.com> Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
This change adds tests for the $dateFromString expression, including cross-operator combination tests that exercise $dateFromString inside other date operators and $toDate/$convert equivalence. It was originally authored by @mitchell-elholm. Closes documentdb#307 Co-authored-by: Mitchell Elholm <mitchell-elholm@users.noreply.github.com> Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
This change adds tests for the $dateToParts expression. It was originally authored by @mitchell-elholm. Closes documentdb#309 Co-authored-by: Mitchell Elholm <mitchell-elholm@users.noreply.github.com> Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
This change adds tests for the $dateToString expression. It was originally authored by @mitchell-elholm. Closes documentdb#310 Co-authored-by: Mitchell Elholm <mitchell-elholm@users.noreply.github.com> Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (7141+0 LOC, 35 files); LLM: Adds new test coverage for four date-related aggregation expressions, touching the compatibility tests directory with moderate scope across multiple operators. If a label is wrong, remove it manually and ping |
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
PatersonProjects
approved these changes
Jul 13, 2026
The nested_field_path case duplicated nested_field: both resolve a two-segment dotted path into a one-level nested object holding a date string, expecting the same parsed date. Only the field names differed, so it added no coverage. Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for the
$dateFromParts,$dateFromString,$dateToParts, and$dateToStringexpressions. The tests were originally authored by @mitchell-elholm.Closes #306, #307, #309, #310