Add $dayOfWeek, $dayOfMonth, $dayOfYear tests#681
Open
danielfrankcom wants to merge 6 commits into
Open
Conversation
This change adds tests for the $dayOfMonth expression. It was originally authored by @mitchell-elholm. Closes documentdb#312 Co-authored-by: Mitchell Elholm <mitchell-elholm@users.noreply.github.com> Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
This change adds tests for the $dayOfWeek expression. It was originally authored by @mitchell-elholm. Closes documentdb#313 Co-authored-by: Mitchell Elholm <mitchell-elholm@users.noreply.github.com> Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
This change adds tests for the $dayOfYear expression. It was originally authored by @mitchell-elholm. Closes documentdb#314 Co-authored-by: Mitchell Elholm <mitchell-elholm@users.noreply.github.com> Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage); effort from diff stats (4978+0 LOC, 27 files); LLM: Adds new test coverage for three date expression operators, closing three tracked issues, touching the compatibility tests component. If a label is wrong, remove it manually and ping |
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
PatersonProjects
suggested changes
Jul 13, 2026
PatersonProjects
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Just a couple potential duplicates and a couple potential additions
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
PatersonProjects
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for the
$dayOfWeek,$dayOfMonth, and$dayOfYearexpressions. They were originallyauthored by @mitchell-elholm.
Closes #312, #313, #314