[CI] Validate Symbol Order - Take 2 - #66
Merged
Merged
Conversation
…e [Super Mario Sunshine Decompilation](https://github.com/doldecomp/sms/blob/main/tools/validate-symbol-order.py), this script is incredibly useful in helping identify the function symbol order based on the original linker map files that some decompilations have. The next step is to add this script into the CI process for mkdd similarly to how [sms already does this](doldecomp/sms@32a9cad).
This reverts commit 7bc3900.
Accidentally used the incorrect debug info map file.
Contributor
Author
|
@SwareJonge this is now good to go. Tested with a few files and it picked up the changed, compared things correctly and reverting the changes to the files I modified reset everything accordingly. Now I can sleep peacefully. 😆😴 |
MB60893
marked this pull request as ready for review
August 5, 2026 16:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally created by Mrkol as part of the Super Mario Sunshine Decompilation, this script is incredibly useful in helping identify the function symbol order based on the original linker map files that some decompilations have.
The next step is to add this script into the CI process for mkdd similarly to how sms already does this.
*First PR abandoned after submodules accidentally got included, leading to some errors which made me start over.