Skip to content

GC2D/GCConsole2: match startAppearCoin - #153

Closed
KakarottoCake wants to merge 1 commit into
doldecomp:mainfrom
KakarottoCake:gcconsole2-round2
Closed

GC2D/GCConsole2: match startAppearCoin#153
KakarottoCake wants to merge 1 commit into
doldecomp:mainfrom
KakarottoCake:gcconsole2-round2

Conversation

@KakarottoCake

Copy link
Copy Markdown
Contributor

Summary

  • spell the coin-counter pane visibility test explicitly
  • match TGCConsole2::startAppearCoin

Results

  • GCConsole2: 26/60 -> 27/60
  • project-wide: 8097/12881 -> 8098/12881

Testing

  • full bare ninja (mario.dol: OK)
  • GCConsole2 symbol linkage validation
  • local CI

@decomp-dev

decomp-dev Bot commented Aug 27, 2026

Copy link
Copy Markdown

Report for GMSJ01 (2fdeee7 - e2e1e16)

📈 Matched code: 37.45% (+0.01%, +316 bytes)

✅ 1 new match
Unit Item Bytes Before After
mario/GC2D/GCConsole2 TGCConsole2::startAppearCoin() +1 99.86% 100.00%

@Mrkol

Mrkol commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Fakematch, make the clanker tackle everything BUT stack frame sizes.

@Mrkol Mrkol closed this Aug 27, 2026
@KakarottoCake
KakarottoCake deleted the gcconsole2-round2 branch August 27, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants