Duration & Metrics for IRS in FinancePy: Validation Against Bond Math by DONALD J. SMITH - #229
Merged
domokane merged 12 commits intoSep 19, 2026
Conversation
Calculation of the Macaulay Duration and Modified_Duration in an Interest Rate Swap Based on Bond Math: The Theory Behind the Formulas, Second Edition by Donald J. Smith
fix duration method
Owner
|
Hi - Can you just have one function. Use the class member fixed_leg_type to determine whether someone is a payer or receiver. or |
1. Use the class member fixed_leg_type(SwapTypes.PAY or SwapTypes.RECEIVE) to determine whether a counterparty is a buyer or seller, and calculate the Macaulay duration, modified duration, basis point value (BPV), and present value change of the interest rate swap (IRS). 2. Updated the notebook: FINIBORSWAP_ReplicationBONDMATHDurationExample.ipynb.
Contributor
Author
|
Contributor
Author
|
No problem, let me run a quick test : )
YONG LI
---- Replied Message ----
***@***.***>Date9/19/2026 ***@***.***>***@***.***>,
***@***.***>SubjectRe: [domokane/FinancePy] Duration & Metrics for IRS in FinancePy:Validation Against Bond Math by DONALD J. SMITH (PR #229)
domokane left a comment (domokane/FinancePy#229)
Hi - I am ready to merge but I need a unit test. This is a basic requirement. Can you add a test to test_FinIborSwap.py.
Thanks.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wow, Doctor, it's really great to meet you!
Based on Bond Math: The Theory Behind the Formulas, Second Edition, I have implemented duration and other metrics for interest rate swaps in FinancePy(ibor_swap.py) and compared the results with those presented in the Bond Math book(FinancePy>notebooks>products>rates>FINIBORSWAP_ReplicationgBONDMATHDurationExample.ipynb). The results are largely consistent, with small differences likely due to date conventions.
Have a nice day.