feat: add granola-engineer Cursor plugin - #19
donny-devops wants to merge 1 commit into
Conversation
Ship a thin kit-specific plugin (agent, /granola-engineer command, skill, always-on meeting rule, Granola MCP) under plugins/granola-engineer, mirror it in .cursor/ so clones load it, and fail tests if the overlay drifts. Co-authored-by: Adonis Jimenez <donny-devops@users.noreply.github.com>
ECC Tools / Security EvidenceCommit: Security scanner evidence required (action_required) Detected 1 security-sensitive predictive risk signal(s) without scanner evidence. Mode: enforce Findings:
Touched security-sensitive paths:
Expected evidence:
Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / PR Risk TaxonomyCommit: PR taxonomy review recommended (neutral) Detected 3 PR taxonomy bucket(s): Security Evidence, Install Manifest Integrity, CI/CD Recommendation. Scanned 18 changed file(s). Roadmap taxonomy buckets: Security EvidenceSecurity-sensitive changes should carry explicit scanner, code-scanning, or focused regression evidence. Signals:
Paths:
Install Manifest IntegrityInstall manifests, plugin metadata, and shipped skills should stay synchronized with user-facing setup guidance. Signals:
Paths:
CI/CD RecommendationCI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work. Signals:
Paths:
Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / Reference Set ReadinessCommit: Reference set readiness gaps detected (neutral) Reference evidence present for 1/7 areas (14%) across 18 changed file(s). This check is based on files changed in this PR. Repository-level readiness is still reported by
Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / Hosted Promotion ReadinessCommit: Hosted promotion readiness passed (success) No hosted promotion evidence gaps detected across 18 changed file(s); 0 corpus scenarios had matching evidence. This check compares PR file changes against the evaluator/RAG promotion corpus in No evaluator corpus scenarios matched this PR. Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
There was a problem hiding this comment.
Review Summary
This PR adds a Cursor plugin for Granola integration to anchor FastAPI development to meeting context. The implementation includes comprehensive test coverage and proper documentation.
Critical Issues (2)
- PII exposure: Personal email address committed to marketplace.json - should use generic or organization email
- Duplicate section header: "Commit messages" appears twice in CONTRIBUTING.md
Overall Assessment
The plugin structure is well-organized with proper mirroring between plugins/ and .cursor/ directories. Tests validate plugin manifests, required files, and overlay synchronization. Once the identified issues are addressed, this will be ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
| ## Commit messages | ||
|
|
There was a problem hiding this comment.
Remove duplicate section header "Commit messages". The section header appears on both line 54 and line 56.
| "name": "fastapi-starter-kit-plugins", | ||
| "owner": { | ||
| "name": "donny-devops", | ||
| "email": "mr.adonisjimenez@gmail.com" |
There was a problem hiding this comment.
🛑 PII Exposure: Personal email address is publicly committed to version control. Replace with a generic or organization email address to avoid spam and privacy concerns.
| "email": "mr.adonisjimenez@gmail.com" | |
| "email": "plugins@donny-devops.example.com" |
Summary
plugins/granola-engineer/(agent,/granola-engineercommand, skill, always-on meeting rule, Granola MCP). This is not a fork of the official Granola marketplace plugin..cursor/so clones load the agent without a Marketplace install..cursor-plugin/marketplace.jsonlists the plugin for team marketplace import.tests/test_plugin.pychecks manifests, required files, and overlay drift./opscatalog is not live Cloudflare Analytics.Test plan
ruff check .andruff format --check .pytest -v(80 passed, including 6 plugin fixture tests)plugins/granola-engineer//granola-engineeris available; first Granola MCP call can sign in (needs a Granola account in the desktop app)