Reduce allocations and improve throughput - #619
Merged
Conversation
| { | ||
| if (_factory is Func<T> factory) | ||
| { | ||
| _value = factory(); |
There was a problem hiding this comment.
If I am not mistaken, without setting _factory to null, the _value will be recalculated on every access to Value property.
Suggested change:
if (_factory is Func<T> factory)
{
_value = factory();
+ _factory = null;
}
Member
Author
There was a problem hiding this comment.
Ah yeah, I forgot to add that line -.-
PRs are welcome, otherwise I'll put one up later this evening.
This was referenced Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This targets a few different hot spots found in the profiler.