Skip to content

Added special handling of bool to byte remapping in indirect fields. … #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 1 commit into from
Jan 5, 2026
Merged

Added special handling of bool to byte remapping in indirect fields. … #659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions sources/ClangSharp.PInvokeGenerator/PInvokeGenerator.VisitDecl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,6 +923,19 @@ private void VisitIndirectFieldDecl(IndirectFieldDecl indirectFieldDecl)
var accessSpecifier = GetAccessSpecifier(anonymousRecordDecl, matchStar: true);

var typeName = GetRemappedTypeName(fieldDecl, context: null, type, out _);

if (!_config.GenerateDisableRuntimeMarshalling && typeName.Equals("bool", StringComparison.Ordinal))
{
// bool is not blittable when DisableRuntimeMarshalling is not specified, so we shouldn't use it for structs that may be in P/Invoke signatures
typeName = "byte";
}

if (_config.GenerateCompatibleCode && typeName.StartsWith("bool*", StringComparison.Ordinal))
{
// bool* is not blittable in compat mode, so we shouldn't use it for structs that may be in P/Invoke signatures
typeName = typeName.Replace("bool*", "byte*", StringComparison.Ordinal);
}

var name = GetRemappedCursorName(fieldDecl);
var escapedName = EscapeName(name);

Expand Down