Return a success exit code for --version - #724
Merged
Merged
Conversation
The --version handler printed the version info and then set an exit code of -1, copied from the argument-error return paths. Version is an informational request, so it should exit 0 to match the convention of clang --version and dotnet --version. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--versionhandler printed the version banner and then setcontext.ExitCode = -1, copied from the surrounding argument-error return paths.--versionis an informational request that completed successfully, so it should exit0-- matching the convention ofclang --versionanddotnet --version, and avoiding a spurious failure signal for anything that shells out to query the version.Note
This PR description was drafted by Copilot on my behalf.