Bump to xamarin/monodroid/main@9b3a37af#6405
Merged
Merged
Conversation
Member
Author
|
Test failed 3 times, need to investigate: |
jonathanpeppers
marked this pull request as draft
October 20, 2021 20:02
Changes: xamarin/monodroid@07a99d7...9b3a37a * [tools/msbuild] <GetPrimaryCpuAbi/> should not select 32-bit ABIs
jonathanpeppers
force-pushed
the
monodroid-9b3a37af
branch
from
October 20, 2021 20:40
670d276 to
5cca147
Compare
This test was failing under .NET 6 because it was doing:
<RuntimeIdentifiers>android-arm;android-x86</RuntimeIdentifiers>
This situation wouldn't even deploy on an API 31 emulator, so we
should just add `x86_64` in this test.
jonathanpeppers
force-pushed
the
monodroid-9b3a37af
branch
from
October 21, 2021 14:31
5cca147 to
f42744c
Compare
jonathanpeppers
marked this pull request as ready for review
October 22, 2021 13:25
dellis1972
approved these changes
Oct 22, 2021
jonathanpeppers
added a commit
that referenced
this pull request
Oct 22, 2021
Context: #6353 Changes: xamarin/monodroid@07a99d7...9b3a37a * xamarin/monodroid@9b3a37af1: [tools/msbuild] <GetPrimaryCpuAbi/> should not select 32-bit ABIs (#1228) Update `MonoAndroidExportTest.MonoAndroidExportReferencedAppStarts()` under .NET 6 to add `x86_64`, e.g. `$(AndroidSupportedAbis)`=`armeabi-v7a;x86;x86_64`. This is needed because the API-31 emulator only supports x86_64, not x86.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: https://github.com/xamarin/monodroid/compare/07a99d79...9b3a37af
<GetPrimaryCpuAbi/>should not select 32-bit ABIs